Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send IP address of Matter device for on network commissioning #4069

Merged

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Dec 21, 2023

Summary

Requires: home-assistant/core#106237

When using matter/commission_on_network (commissioning started from the frontend), also send the IP address returned by the system to the server in order to fix home-assistant-libs/python-matter-server#463. Read the issue + linked PR for more details.

The websocket message will now look like this:

{
    "id": 3,
    "type": "matter/commission_on_network",
    "pin": 1234,
    "ip_addr": "fd82:c9e9:5cb7:1:2c5c:ed99:ecf:4460"
}

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

@jpelgrom jpelgrom changed the title Send IP address of Matter device during on network commissioning Send IP address of Matter device for on network commissioning Dec 21, 2023
@jpelgrom jpelgrom force-pushed the matter-commission-discriminator branch from 972559e to 54672be Compare December 22, 2023 13:31
@jpelgrom jpelgrom marked this pull request as ready for review December 27, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Something went wrong" when commissioning through Android app
3 participants