Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to refresh interval to avoid text getting cut off #4119

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

dshokouhi
Copy link
Member

Summary

We got a review failure from Google with a screenshot this time!

image

Adding padding to this screen to prevent the text from getting cut off like that. I tried to move to ThemeLazyColumn however the rotary input does not play nice so the best option seemed to be adding some sane padding

Screenshots

After fix using largest font size in Pixel Watch (one side effect of this change is that not many elements are visible in the picker however we do need to push things down a bit so this might be expected in larger screen sizes):

image

Still behaves fine in default text size:

image

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@JBassett JBassett enabled auto-merge (squash) January 6, 2024 01:05
@JBassett JBassett merged commit 39b19b7 into home-assistant:master Jan 6, 2024
4 checks passed
@jpelgrom
Copy link
Member

jpelgrom commented Jan 6, 2024

You only needed horizontal padding here, now it's quite hard to see the text can scroll on the largest size...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants