Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'Refresh interval' title with icon #4144

Merged

Conversation

jpelgrom
Copy link
Member

Summary

To (hopefully) finally address review failures about text being cut off on round screens replace it with an icon. Same icon as used in the previous screen so should be pretty clear.

Screenshots

Picker with a clock with cog icon above it

As a reminder, the preference chip:
Refresh interval: Manual, with the same icon

Link to pull request in Documentation repository

n/a

Any other notes

 - To (hopefully) finally address review failures about text being cut off on round screens replace it with an icon. Same icon as used in the previous screen so should be pretty clear.
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better fix to use a icon here!

@JBassett JBassett merged commit ff2b0ec into home-assistant:master Jan 24, 2024
4 checks passed
@jpelgrom jpelgrom deleted the refresh-interval-picker-icon-title branch January 24, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants