Remove Thread credential sync from start of Matter commissioning flow #4150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After discussion with @agners, remove Thread credential syncing from the start of the Matter commissioning flow. There are 2 major reasons for this:
The alternative for the user is to use the manual 'import credentials' button in the frontend (matching iOS), or access the sync option in the app settings > troubleshooting menu.
This should result in a more reliable user experience when using Matter and prevents unstable/unfinished Thread work on the core and app side 'polluting a real device'. Adding a comment in the code in case/when we revisit this in the future.
Screenshots
n/a / the Thread permission dialog will no longer show up when doing Matter commissioning
Link to pull request in Documentation repository
n/a, this behavior wasn't documented, general Thread companion app import/export documentation to be done independently
Any other notes