Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assist dialog state when transitioning locked<>unlocked #4235

Merged
merged 1 commit into from Feb 29, 2024

Conversation

jpelgrom
Copy link
Member

Summary

Fixes #4211 (in later comment), fixes #4231

Update the flags for showing the Assist dialog when locked to:

  • prevent unintentional resuming in a different locked state (= was unlocked and Assist open, lock, keyguard should be on top)
  • clear contents when resumed in a different locked state intentionally (assistant intent action)

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

 - Update the dialog flags for showing the Assist dialog when locked to prevent unintentional resuming in another locked state and clear contents when resumed intentionally (assistant intent action)
@JBassett JBassett merged commit 835b50f into home-assistant:master Feb 29, 2024
4 checks passed
@jpelgrom jpelgrom deleted the assist-auth-context branch March 1, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assist can be accessed when phone is locked Assist dialog drains battery when screen is off
2 participants