Add some missing states for audio sensor and correct mic muted intent condition #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
changed the title
Don't forget to also update the |
ah good catch! |
jpelgrom
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed we got new Audio Manager modes for our sensor so adding in the new possible states
https://developer.android.com/reference/android/media/AudioManager#MODE_COMMUNICATION_REDIRECT
https://developer.android.com/reference/android/media/AudioManager#MODE_CALL_REDIRECT
I also noticed that our mic muted SDK condition was incorrect so split it up to be correct.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1059
Any other notes