Fix Biometric Unlock & Enhancement #625

neopilou · 2020-06-12T09:55:21Z

Fix issues Lock screen does not appear when the app is resumed from background #555 and Biometrics Visual & Accessibility improvements #587
Delete "Lock" folder
Add Prompt Unlock function directly in WebViewActivity
Added session timeout in app settings :
App is locked when resumed (after session timedout)
When the app is locked, the screen is blurred (no quite obnoxious splash screen to look at), which allows the HA frontend to be loaded before or during unlocking :
No button needs to be touched for unlock
When the unlock prompt is displayed, the back button close the app

- Delete "Lock" folder - Add Prompt Unlock function directly in WebViewActivity - Added session timeout in app settings - App is locked when resumed (after session timedout) - When the application is locked, the screen is blurred (no quite obnoxious splash screen to look at), which allows the HA frontend to be loaded before or during unlocking - No button needs to be touched for unlock - When the unlock prompt is displayed, the back button close the app - Fix issues #555 and #587

- Add Prompt Unlock when resume after session timedout in App Settings

JBassett

I think the blur affect is pretty awesome. Personally I'm not a fan of adding the complexity for the timeout. The logic being added is a running cost anytime we add a new view or menu we need to add timeout logic where the old way was just part of launching the app. Even in your PR you added 2 different ways to set the timeout time. Just my personal take on it so looking for others to chime in.

On another note I know that @balloob also had concerns about adding more preferences and this seems like an excessive one.

...c/main/java/io/homeassistant/companion/android/data/integration/IntegrationRepositoryImpl.kt

app/build.gradle.kts

app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt

app/src/main/java/io/homeassistant/companion/android/settings/SettingsFragment.kt

JBassett · 2020-06-18T17:58:02Z

app/src/main/java/io/homeassistant/companion/android/settings/SettingsFragment.kt

+    }
+
+    override fun onPause() {
+        presenter.setSessionExpireMillis((System.currentTimeMillis() + (presenter.sessionTimeOut() * 1000)))


Won't this set the lock time in the future onPause even if the app is locked? Couldn't you just put to background in settings then return to app and it would be unlocked?

No, but we can resume the app with WebViewActivity and not with SettingsActivity when user leaving application while settings are displayed

balloob · 2020-06-18T22:28:27Z

This option is okay. We'll eventually need some cleanup of the options. Not sure if a slider is easy to manage it here, maybe just a dialog prompting for text when you tap on it is better ?

- Added putInt() an getInt() methods in localStorage & localStorageImpl - Deleted PREF_UNLOCK constant ED in IntegrationRepositoryImpl.kt - Moved "com.eightbitlab:blurview:1.6.3" in Config.kt - The "promptForUnlock()" method is no longer duplicated and is now a "Authenticator" class with "authenticate()" methods - EditTextPreference is used rather than SeekBarPreference in app settings

Added modified & forgotten file LocalStorageImpl.kt

…biometric

neopilou · 2020-06-23T10:52:22Z

EditTextPreference is used rather than SeekBarPreference in app settings :

balloob · 2020-06-23T15:55:52Z

Can we update the strings for the dialog.

Header update: "Home Assistant is locked"
Description: drop this

Deleted promptDialog.setMessage Modified promptDialog.setTitle : - "Home Assistant is locked" when open or resume app - "Confirm to continue" when activate "Lock app" in app settings

neopilou · 2020-06-24T08:59:10Z

Modified promptDialog.setTitle :

"Home Assistant is locked" when open or resume app :
"Confirm to continue" when activate "Lock app" in app settings :

JBassett · 2020-07-03T11:06:57Z

app/src/main/java/io/homeassistant/companion/android/authenticator/Authenticator.kt

+    val CANCELED = 2
+    val SUCCESS = 1
+    val ERROR = 0


Suggested change

val CANCELED = 2

val SUCCESS = 1

val ERROR = 0

companion object {

const val CANCELED = 2

const val SUCCESS = 1

const val ERROR = 0

}

Change made

JBassett · 2020-07-03T11:09:10Z

app/src/main/java/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt

@@ -59,6 +59,7 @@ class SettingsPresenterImpl @Inject constructor(
                "connection_internal" -> (urlUseCase.getUrl(true) ?: "").toString()
                "connection_external" -> (urlUseCase.getUrl(false) ?: "").toString()
                "registration_name" -> integrationUseCase.getRegistration().deviceName
+                "session_timeout" -> integrationUseCase.getSessionTimeOut().toString()


Is this still needed?

Yes, it's still necessary if the user is allowed to choose time in second to session timedout

What exactly are we allowing to configure, how long the app can be unused until we ask again for biometrics ?

Yes that's exactly it

I'm personally a big believer in sane defaults that one cannot override. Having a 1000 options is going to be a pain to maintain. How will we show all the app options to the user while not hiding options?

JBassett · 2020-07-03T11:09:20Z

app/src/main/java/io/homeassistant/companion/android/settings/SettingsPresenterImpl.kt

@@ -69,6 +70,7 @@ class SettingsPresenterImpl @Inject constructor(
            when (key) {
                "connection_internal" -> urlUseCase.saveUrl(value ?: "", true)
                "connection_external" -> urlUseCase.saveUrl(value ?: "", false)
+                "session_timeout" -> integrationUseCase.sessionTimeOut(value.toString().toInt())


This still needed?

Yes, it's still necessary if the user is allowed to choose time in second to session timedout

app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt

app/src/main/java/io/homeassistant/companion/android/settings/SettingsFragment.kt

homeassistant added the cla-signed label Jun 12, 2020

neopilou and others added 5 commits June 12, 2020 13:24

delete old reference

b017d96

Add implementation

e691ab9

Fix Settings Prompt Unlock

59793c4

- Add Prompt Unlock when resume after session timedout in App Settings

Merge branch 'master' into biometric

7949c17

Replace Timeout icon

1947f63

JBassett requested changes Jun 18, 2020

View reviewed changes

neopilou and others added 5 commits June 23, 2020 07:53

Merge branch 'master' into biometric

b4f2506

Forgotten LocalStorageImpl.kt

d17fd88

Added modified & forgotten file LocalStorageImpl.kt

Merge branch 'biometric' of https://github.com/neopilou/android into …

078fe0f

…biometric

Fix AndroidManifest.xml

26a401c

neopilou requested a review from JBassett June 23, 2020 09:33

neopilou and others added 2 commits June 23, 2020 11:48

Fix

d75fcea

Fix

9493ca0

neopilou added 2 commits June 24, 2020 09:57

Modified prompDialog

5687b56

Deleted promptDialog.setMessage Modified promptDialog.setTitle : - "Home Assistant is locked" when open or resume app - "Confirm to continue" when activate "Lock app" in app settings

fix

0b79a81

JBassett requested changes Jul 3, 2020

View reviewed changes

Fix

ff17efd

neopilou requested review from JBassett and balloob July 3, 2020 13:24

Merge branch 'master' into biometric

ab1e652

JBassett approved these changes Jul 5, 2020

View reviewed changes

This was linked to issues Jul 5, 2020

Biometrics Visual & Accessibility improvements #587

Closed

Lock screen does not appear when the app is resumed from background #555

Closed

JBassett merged commit 7565560 into home-assistant:master Jul 5, 2020

JBassett added enhancement New feature or request minor A minor change - Bumps minor build number labels Jul 6, 2020

jnicolson mentioned this pull request Jul 13, 2020

Incorrect English label - lokalise overwrote correct one #667

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Biometric Unlock & Enhancement #625

Fix Biometric Unlock & Enhancement #625

neopilou commented Jun 12, 2020

JBassett left a comment

JBassett Jun 18, 2020

neopilou Jun 23, 2020

balloob commented Jun 18, 2020

neopilou commented Jun 23, 2020

balloob commented Jun 23, 2020

neopilou commented Jun 24, 2020

JBassett Jul 3, 2020

neopilou Jul 3, 2020

JBassett Jul 3, 2020

neopilou Jul 3, 2020

balloob Jul 3, 2020

neopilou Jul 3, 2020

balloob Jul 3, 2020

JBassett Jul 3, 2020

neopilou Jul 3, 2020

-    val CANCELED = 2
-    val SUCCESS = 1
-    val ERROR = 0
+    companion object {
+        const val CANCELED = 2
+        const val SUCCESS = 1
+        const val ERROR = 0
+    }

Fix Biometric Unlock & Enhancement #625

Fix Biometric Unlock & Enhancement #625

Conversation

neopilou commented Jun 12, 2020

JBassett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balloob commented Jun 18, 2020

neopilou commented Jun 23, 2020

balloob commented Jun 23, 2020

neopilou commented Jun 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment