Hot fix removing authentication from settings. #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was causing crashes.
JBassett
added
bug
|
Because if you leave the application when you are in the settings and you resume (not restart) the app later, you can access the settings without authentication. This can allow anyone to access the settings and disable authentication. So we have two solutions (maybe others), either we ask for an authentication, or we force the resume of the app in the WebViewActivity, and not in the SettingsActivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was causing crashes and I'm not sure if we need on the settings. If you have gotten into the application we should assume you are totally authenticated.