Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure widget theme colors #732

Merged
merged 2 commits into from Aug 11, 2020

Conversation

dshokouhi
Copy link
Member

Fixes: #729

Dark mode - service call widget
image

Light mode - service call widget
image

Dark mode - entity static widget
image

Light mode - entity static widget
image

Recommendation per: https://developer.android.com/guide/topics/ui/look-and-feel/darktheme#widgets_and_custom_notification_views

@dshokouhi dshokouhi changed the title Remove hardcoded colors to be more theme compatible with widgets Fix configure widget theme colors Aug 11, 2020
@JBassett
Copy link
Collaborator

Isn't that style used during onboarding as well? Are we affected by the same situation there?

@dshokouhi
Copy link
Member Author

Onboarding appears to be ok as the buttons have the blue background where they did not previously for the configure widget layouts

Light theme:
image

image

Dark theme:
image

image

@dshokouhi
Copy link
Member Author

@JBassett you are right, firebase retry screen has the same issue. Let me remove from there.

@dshokouhi
Copy link
Member Author

dshokouhi commented Aug 11, 2020

@JBassett do you happen to know what screen this is found on? https://github.com/home-assistant/android/blob/master/app/src/main/res/layout/fragment_manual_setup.xml#L32

I was expecting to see a button label :)

Edit: its actually pictured in my previous comment which seems to be ok, so this must be the only instance its allowed? Its the ok button on the manual setup screen lol

@JBassett
Copy link
Collaborator

do you happen to know what screen this is found on?

That is the manual URL entry for connecting to a Home Assistant instance that you covered with the second set of screenshots.

@JBassett JBassett added bug Something isn't working patch A tiny change - Bumps patch build number labels Aug 11, 2020
@JBassett JBassett merged commit 6e70dff into home-assistant:master Aug 11, 2020
@dshokouhi dshokouhi deleted the fix_configure_widget_theme branch August 16, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed patch A tiny change - Bumps patch build number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating widget action - "ADD FIELD" and "ADD WIDGET" buttons are invisible
3 participants