Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easier way to use of emoji in notifications #741

Merged
merged 3 commits into from Aug 17, 2020

Conversation

chriss158
Copy link
Contributor

With this PR is easier to use emojis in notification.
Just use the emoji shortcode and it will be parsed to the correct unicode code.
It is also possible to use fitzpatrick modifiers to change the skin tone of an emoji.

Modifier Type
馃徎 type_1_2
馃徏 type_3
馃徑 type_4
馃従 type_5
馃徔 type_6

:santa|type_6:

Example:

message: "Now you can easy use emojis :santa|type_6::frog::sparkling_heart: in your notifications :sunglasses::rocket:"
title: "Easier use of Emojis :grinning::thumbsup:"

More on the project site of the library which is used:
https://github.com/vdurmont/emoji-java

Here are a lists of emoji short codes:
https://emojipedia.org/

@chriss158
Copy link
Contributor Author

What went wrong with the validate? On my dev pc i have no issues running linting.

@JBassett
Copy link
Collaborator

  Errors found:
  
  /home/runner/work/android/android/app/build.gradle.kts:47: Error: json defines classes that conflict with classes now provided by Android. Solutions include finding newer versions or alternative libraries that don't have the same problem (for example, for httpclient use HttpUrlConnection or okhttp instead), or repackaging the library using something like jarjar. [DuplicatePlatformClasses]
          serviceCredentialsFile = "firebaseAppDistributionServiceCredentialsFile.json"
                                                                                  ~~~~

@JBassett JBassett added enhancement New feature or request patch A tiny change - Bumps patch build number labels Aug 13, 2020
@chriss158
Copy link
Contributor Author

@JBassett can you help me here? I did not change anything on that. Just added the emoji library. Also android studio complains about that and suggest to suppress lint on that line. But gradlew ktlintFormat doesn't complain.

@JBassett
Copy link
Collaborator

It's gradlew lint that is failing. The dependency you added is pulling in org.json:json which is provided by Android and conflicting. You need to exclude it.

@chriss158
Copy link
Contributor Author

Thanks for help. Is fixed now 馃憤

@JBassett JBassett merged commit 6bc1948 into home-assistant:master Aug 17, 2020
@chriss158 chriss158 deleted the emoji branch February 4, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed enhancement New feature or request patch A tiny change - Bumps patch build number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants