Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate attributes showing in UI #765

Merged
merged 1 commit into from Aug 15, 2020
Merged

Fix duplicate attributes showing in UI #765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/main/java/io/homeassistant/companion/android/sensors/SensorDetailFragment.kt
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@ import androidx.preference.Preference
import androidx.preference.PreferenceCategory
import androidx.preference.PreferenceFragmentCompat
import androidx.preference.SwitchPreference
import androidx.preference.contains
import io.homeassistant.companion.android.R
import io.homeassistant.companion.android.common.dagger.GraphComponentAccessor
import io.homeassistant.companion.android.database.AppDatabase
Expand Down Expand Up @@ -94,12 +95,14 @@ class SensorDetailFragment(
it.isVisible = false
else {
sensorData?.attributes?.keys?.forEach { key ->
val pref = Preference(requireContext())
val pref = findPreference("attribute_$key") ?: Preference(requireContext())
pref.key = "attribute_$key"
pref.title = key
pref.summary = sensorData.attributes[key]?.toString() ?: ""
pref.isIconSpaceReserved = false

it.addPreference(pref)
if (!it.contains(pref))
it.addPreference(pref)
}
}
}
Expand Down