Enhance PhoneStateSensorManager with carrier information sensors #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Aug 19, 2020
JBassett
requested changes
Aug 19, 2020
app/src/main/java/io/homeassistant/companion/android/sensors/PhoneStateSensorManager.kt
Outdated
Show resolved
Hide resolved
JBassett
added
enhancement
JBassett
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768
PR enhance current PhoneStateSensorManager with 2 new sensors SIM_1 and SIM_2.
Sensors require api level 22 or above. Moreover attributes {"carrier id", "mcc", "mnc", "is opportunistic", "data roaming"} require api 29+
I didn't add OnSubscriptionsChangedListener so sensors will be updated only on regular basis