Fix geocoded crash, report expected minimum accuracy for location #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
changed the title
JBassett
reviewed
Aug 27, 2020
app/src/full/java/io/homeassistant/companion/android/sensors/GeocodeSensorManager.kt
Outdated
Show resolved
Hide resolved
Closed
JBassett
added
bug
JBassett
approved these changes
Aug 27, 2020
anyuta1166
added a commit
to anyuta1166/android
that referenced
this pull request
Aug 27, 2020
Fix geocoded crash, report expected minimum accuracy for location (home-assistant#832)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #830
Also fixes a edge case where sometimes we were sending an invalid
gps_accuracyattribute which was less than 0.Example error from HA:
Received invalid webhook payload: value must be at least 0 for dictionary value @ data['gps_accuracy']. Got -2147478andReceived invalid webhook payload: value must be at least 0 for dictionary value @ data['gps_accuracy']. Got -2147471During these errors all updates do not come through so when we detect that accuracy >= 0 we will send the real value, otherwise we will send
0which is the bare minimum that HA will accept