Add description for each sensor on details screen, only show device class and icon if they are set #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
reviewed
Aug 30, 2020
app/src/main/java/io/homeassistant/companion/android/sensors/SensorDetailFragment.kt
Outdated
Show resolved
Hide resolved
JBassett
reviewed
Aug 30, 2020
app/src/main/java/io/homeassistant/companion/android/sensors/SensorDetailFragment.kt
Outdated
Show resolved
Hide resolved
JBassett
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to add a description for each sensor so users know what they are getting if they decide to enable/disable it. Not a lot of details just enough to tell them what to expect. Made sure to warn the users as well for certain sensors that may not behave as expected (i.e. Next Alarm) Also only show icon and device class if the sensor has it set.
We could consider linking directly to the docs if users find that to be helpful but I think one link to the docs should suffice for now.