Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only register once for hardware sensors #873

Merged
merged 2 commits into from Sep 3, 2020
Merged

Only register once for hardware sensors #873

merged 2 commits into from Sep 3, 2020

Conversation

dshokouhi
Copy link
Member

A few fixes for the hardware sensors:

  • Lets keep track of our listeners and only register once if we have not already registered. If the app is killed by the user or the system these listeners are already removed, this is to prevent ourselves from registering again if we did not receive a onSensorChanged event.
  • Adds some logging around when listeners are registered/unregistered.
  • Remove unused context

@JBassett JBassett merged commit bd2cfb5 into home-assistant:master Sep 3, 2020
@dshokouhi dshokouhi deleted the hardware_sensor_listener_fix branch February 12, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBassett JBassett JBassett approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dshokouhi @JBassett @homeassistant