Make minimum accuracy user configurable

[anyuta1166]

Make minimum accuracy user configurable.
It's a long awaited feature and also fixes #868

[anyuta1166]

Oops, it seems that I broke geocode sensor. Location sensor works fine though.

Any ideas? I've copied the code from LocationSensorManager. What I've missed?

09-07 11:31:33.005 20427 20427 E GeocodeSM: Failed to get geocoded location
09-07 11:31:33.005 20427 20427 E GeocodeSM: kotlin.UninitializedPropertyAccessException: lateinit property integrationUseCase has not been initialized
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at io.homeassistant.companion.android.sensors.GeocodeSensorManager.getIntegrationUseCase(GeocodeSensorManager.kt:29)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at io.homeassistant.companion.android.sensors.GeocodeSensorManager$getMinimumAccuracy$1.invokeSuspend(GeocodeSensorManager.kt:57)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at io.homeassistant.companion.android.sensors.GeocodeSensorManager.getMinimumAccuracy(GeocodeSensorManager.kt:56)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at io.homeassistant.companion.android.sensors.GeocodeSensorManager.access$getMinimumAccuracy(GeocodeSensorManager.kt:16)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at io.homeassistant.companion.android.sensors.GeocodeSensorManager$updateGeocodedLocation$1.onSuccess(GeocodeSensorManager.kt:73)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at io.homeassistant.companion.android.sensors.GeocodeSensorManager$updateGeocodedLocation$1.onSuccess(GeocodeSensorManager.kt:16)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at com.google.android.gms.tasks.zzn.run(Unknown Source:4)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at android.os.Handler.handleCallback(Handler.java:873)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at android.os.Handler.dispatchMessage(Handler.java:99)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at android.os.Looper.loop(Looper.java:193)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at android.app.ActivityThread.main(ActivityThread.java:6923)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at java.lang.reflect.Method.invoke(Native Method)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
09-07 11:31:33.005 20427 20427 E GeocodeSM:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:870)

[anyuta1166]

Sorry for me being a newbie :-) Seems like I've missed to add some code. Fixed.

Seems to work fine now.

[skynetua]

I thougth about this feature like setting per sensor but not like integretionUsecase settng. It is not so global to be defined there as for me. We could store setting required for particular sensor manager in the daabase and show them in sensor details fragment. In sensor manager we will be able to get it by existing sensorDao object.

[anyuta1166]

I thougth about this feature like setting per sensor but not like integretionUsecase settng. It is not so global to be defined there as for me.

It affects 2 sensors - location sensor and geocoded sensor. And the setting should be the same for both.

[anyuta1166]

I also wonder if we should remove doubling minimum accuracy for the last attempt after making it configurable to avoid user confusion.

[dshokouhi]

I thougth about this feature like setting per sensor but not like integretionUsecase settng. It is not so global to be defined there as for me.

It affects 2 sensors - location sensor and geocoded sensor. And the setting should be the same for both.

It does use 2 sensors but it's a little odd having it here because not all users will grant the app location permissions and if they don't we shouldn't show this option to them. I believe the logic for geocoded is not the same as location because we don't do the retry attempts in geocoded like we do for the device tracker. We also need to hide it from minimal users too.

I also wonder if we should remove doubling minimum accuracy for the last attempt after making it configurable to avoid user confusion.

I think we may want to let users keep things as the current default if they are happy with the current implementation but if a user changes this then yes we we should not double it. Not sure what the others think about this.

[dshokouhi]

Just a general comment on the input field itself, may need to discuss whats best for its behavior.

[anyuta1166]

not all users will grant the app location permissions and if they don't we shouldn't show this option to them.

Implemented this.

[anyuta1166]

Rebased after #895.

[anyuta1166]

Fixed a small copy-paste error. :-)

[JBassett]

After thinking about this for a while I think we want this to be a per location update type setting, not just a global one if we are going to make it adjustable. Take for example if you request an accurate location, I might want an accurate location vs a zone change I might be ok with less accurate.

[anyuta1166]

So are you going to leave it global and unconfigurable until someone comes up with a better PR?

[JBassett]

Closing in favor of #964