Hide NFC if the device reports it has no hardware #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
requested changes
Sep 16, 2020
There was a problem hiding this comment.
We should also add this here so the UI doesn't think the device can write NFC tags: https://github.com/home-assistant/android/blob/master/app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt#L362
JBassett
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was helping out a user in Discord who could not see the NFC option and it ended up being his HA version was not on 0.114 or higher. While inspecting the code I noticed we do not check for NFC hardware when we look to make the option visible. Now we will do a check with package manager and if successful we will continue with current logic looking at the HA version, if unavailable the option will be hidden. Tested on my pixel 4 xl that has NFC support as well as 2 amazon tablets that do not have NFC, NFC remains hidden on tablets that don't have the hardware.