Add deadband setting for last reboot sensor #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
requested changes
Sep 19, 2020
app/src/main/java/io/homeassistant/companion/android/sensors/LastRebootSensorManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/sensors/LastRebootSensorManager.kt
Outdated
Show resolved
Hide resolved
dshokouhi
changed the title
JBassett
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #910
As we noticed that there may be a difference between cell phone and cell tower time lets add an
offsetfor the last reboot sensor. The default value is set to60000or 1 minute, we can adjust it but I think this should fix the issue for most users. Making it a setting in case they want to make the value larger or smaller. The description has been updated to explain the setting and I have also moved some static strings to be constant values.