-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CarPlay documentation #923
Conversation
07ac3c4
to
5d5a3a0
Compare
Nice to see this! I would say lets also add it to the home page to highlight it more :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and amazing work getting this developed! Just some very small changes to be consistent with the style standards used elsewhere.
I think this feature, when released fully, will merit a blog post on the main website too.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@TomBrien Thank you for your suggestions! I also agree with a blog post on the main website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks good and can be merged once the home-assistant/iOS#2320 is merged.
<!-- Thank you for submitting a Pull Request and helping to improve Home Assistant. Please complete the following sections to help the processing and review of your changes. Please do not delete anything from this template. --> ## Summary <!-- Provide a brief summary of the changes you have made and most importantly what they aim to achieve --> CarPlay implementation that allows you to interact with various entities safely while driving your vehicle. ## Screenshots <!-- If this is a user-facing change not in the frontend, please include screenshots in light and dark mode. --> ## Link to pull request in Documentation repository <!-- Pull requests that add, change or remove functionality must have a corresponding pull request in the Companion App Documentation repository (https://github.com/home-assistant/companion.home-assistant). Please add the number of this pull request after the "#" --> Documentation: home-assistant/companion.home-assistant#923 ## Any other notes <!-- If there is any other information of note, like if this Pull Request is part of a bigger change, please include it here. --> --------- Co-authored-by: Joshua Peisach <itzswirlz2020@outlook.com> Co-authored-by: Bram Kragten <mail@bramkragten.nl> Co-authored-by: Bruno Pantaleão <bruno.ing879@gmail.com>
Co-authored-by: Tom Brien <TomBrien@users.noreply.github.com>
Co-authored-by: Tom Brien <TomBrien@users.noreply.github.com>
Added CarPlay documentation