Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarPlay documentation #923

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

LuisFALopes
Copy link
Contributor

Added CarPlay documentation

@dshokouhi
Copy link
Member

Nice to see this! I would say lets also add it to the home page to highlight it more :)

Copy link
Member

@TomBrien TomBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and amazing work getting this developed! Just some very small changes to be consistent with the style standards used elsewhere.

I think this feature, when released fully, will merit a blog post on the main website too.

docs/carplay/carplay.md Outdated Show resolved Hide resolved
docs/carplay/carplay.md Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 9, 2023 20:45
@home-assistant
Copy link

home-assistant bot commented Mar 9, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@LuisFALopes
Copy link
Contributor Author

LuisFALopes commented Mar 10, 2023

@TomBrien Thank you for your suggestions! I also agree with a blog post on the main website.

@LuisFALopes LuisFALopes marked this pull request as ready for review March 10, 2023 10:23
@home-assistant home-assistant bot requested a review from TomBrien March 10, 2023 10:23
Copy link
Member

@TomBrien TomBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good and can be merged once the home-assistant/iOS#2320 is merged.

src/pages/index.js Outdated Show resolved Hide resolved
bgoncal added a commit to home-assistant/iOS that referenced this pull request Jan 8, 2024
<!-- Thank you for submitting a Pull Request and helping to improve Home
Assistant. Please complete the following sections to help the processing
and review of your changes. Please do not delete anything from this
template. -->

## Summary
<!-- Provide a brief summary of the changes you have made and most
importantly what they aim to achieve -->
CarPlay implementation that allows you to interact with various entities
safely while driving your vehicle.

## Screenshots
<!-- If this is a user-facing change not in the frontend, please include
screenshots in light and dark mode. -->

## Link to pull request in Documentation repository
<!-- Pull requests that add, change or remove functionality must have a
corresponding pull request in the Companion App Documentation repository
(https://github.com/home-assistant/companion.home-assistant). Please add
the number of this pull request after the "#" -->
Documentation: home-assistant/companion.home-assistant#923

## Any other notes
<!-- If there is any other information of note, like if this Pull
Request is part of a bigger change, please include it here. -->

---------

Co-authored-by: Joshua Peisach <itzswirlz2020@outlook.com>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bruno Pantaleão <bruno.ing879@gmail.com>
LuisFALopes and others added 6 commits June 10, 2024 09:53
@bgoncal
Copy link
Member

bgoncal commented Jun 10, 2024

I just reviewed and updated the doc and it should be good to merge in my opinion @TomBrien @frenck

@bgoncal bgoncal merged commit 3edbcbf into home-assistant:master Jun 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants