Skip to content

Commit

Permalink
Correct fjaraskupan post merge review comments (#58796)
Browse files Browse the repository at this point in the history
  • Loading branch information
elupus committed Oct 31, 2021
1 parent f561533 commit 7047205
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion homeassistant/components/fjaraskupan/__init__.py
Expand Up @@ -23,7 +23,7 @@

from .const import DISPATCH_DETECTION, DOMAIN

PLATFORMS = ["binary_sensor", "fan", "light", "sensor", "number"]
PLATFORMS = ["binary_sensor", "fan", "light", "number", "sensor"]

_LOGGER = logging.getLogger(__name__)

Expand Down
3 changes: 2 additions & 1 deletion homeassistant/components/fjaraskupan/fan.py
Expand Up @@ -17,6 +17,7 @@
)
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant, callback
from homeassistant.exceptions import HomeAssistantError
from homeassistant.helpers.entity import DeviceInfo
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.update_coordinator import (
Expand Down Expand Up @@ -50,7 +51,7 @@
}


class UnsupportedPreset(Exception):
class UnsupportedPreset(HomeAssistantError):
"""The preset is unsupported."""


Expand Down
5 changes: 2 additions & 3 deletions homeassistant/components/fjaraskupan/number.py
Expand Up @@ -22,7 +22,7 @@ async def async_setup_entry(
config_entry: ConfigEntry,
async_add_entities: AddEntitiesCallback,
) -> None:
"""Set up sensors dynamically through discovery."""
"""Set up number entities dynamically through discovery."""

def _constructor(device_state: DeviceState) -> list[Entity]:
return [
Expand All @@ -40,7 +40,6 @@ class PeriodicVentingTime(CoordinatorEntity[State], NumberEntity):
_attr_max_value: float = 59
_attr_min_value: float = 0
_attr_step: float = 1
_attr_entity_registry_enabled_default = True
_attr_entity_category = ENTITY_CATEGORY_CONFIG
_attr_unit_of_measurement = TIME_MINUTES

Expand All @@ -50,7 +49,7 @@ def __init__(
device: Device,
device_info: DeviceInfo,
) -> None:
"""Init sensor."""
"""Init number entities."""
super().__init__(coordinator)
self._device = device
self._attr_unique_id = f"{device.address}-periodic-venting"
Expand Down

0 comments on commit 7047205

Please sign in to comment.