Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RadioRA2 Unnamed entities #110038

Closed
MarkzP opened this issue Feb 8, 2024 · 45 comments
Closed

RadioRA2 Unnamed entities #110038

MarkzP opened this issue Feb 8, 2024 · 45 comments
Labels
integration: lutron

Comments

@MarkzP
Copy link

MarkzP commented Feb 8, 2024

The problem

Entity ids for lights, occupancy & some switches are no longer matching Lutron integration names: previously these were formatted as light.[area].[name]. Since 2024.2.0 the entity ids of the same lights are now light.unnamed_device_xx, breaking automations.
Entity names are similarly affected;
Not sure if this is intended or not

What version of Home Assistant Core has the issue?

2024.2.0

What was the last working version of Home Assistant Core?

2024.1.0

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Lutron

Link to integration documentation on our website

https://www.home-assistant.io/integrations/lutron

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response
@home-assistant
Copy link

home-assistant bot commented Feb 8, 2024

Hey there @cdheiser, @wilburCforce, mind taking a look at this issue as it has been labeled with an integration (lutron) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign lutron Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

lutron documentation
lutron source
(message by IssueLinks)

@wilburCforce
Copy link
Contributor

I believe the previous naming was entityType.[area]_[name]
I don't think this was intentional and I have not seen that happen in my instance. My entities all remained the same. @joostlek did the work to create devices which I think might have introduced this. There is some tie in to the device naming in the current architecture. @joostlek can you comment on expected behavior? It appears that the entity no longer specifies a name. The doc seems to indicate that when an entity is the sole purpose of the device that it wouldn't specify a name. Thoughts?

@cdheiser
Copy link
Contributor

cdheiser commented Feb 8, 2024 via email

@joostlek
Copy link
Member

joostlek commented Feb 8, 2024

It should not break automations iirc, since the unique id didn't change. If it did, I don't know what exactly happened.

I think it's strange that the device has no name. Since Wilber can't reproduce it, can @cdheiser send me a message on discord? (You should already have a PM request) and we can try to figure stuff out

@wilburCforce
Copy link
Contributor

@MarkzP it might also be helpful to have some examples from your entity registry which is located in config/.storage/core.entity_registry
The unique_id attribute should be a value of [main repeater guid]_[uuid from xml]
Assuming the data matches up to your xml file it should have kept the same name.
If there was something different in your entity registry before then it would not have matched and I think you would have gotten new entities.

@mib1185 mib1185 mentioned this issue Feb 8, 2024
Open
@MarkzP
Copy link
Author

MarkzP commented Feb 8, 2024

Turns out my RA2 firmware is fairly old, so no device UUID = no entity unique ids = no entities created in the registry

Looks like this suggestion would be very helpful in my case
I no longer have access to the original integration files, so to update the firmware I would have to reprogram the system from scratch, which is something I'm trying to avoid as much as I can

Thanks for your help!

@cdheiser
Copy link
Contributor

cdheiser commented Feb 8, 2024 via email

@BWilky
Copy link

BWilky commented Feb 8, 2024

I believe the previous naming was entityType.[area]_[name] I don't think this was intentional and I have not seen that happen in my instance. My entities all remained the same. @joostlek did the work to create devices which I think might have introduced this. There is some tie in to the device naming in the current architecture. @joostlek can you comment on expected behavior? It appears that the entity no longer specifies a name. The doc seems to indicate that when an entity is the sole purpose of the device that it wouldn't specify a name. Thoughts?

This only happens when you re-initialize the integration. Mine were fine, but I made major updates with phantom keypads and needed to clear out the registry to fix some hanging issues. Upon doing so, it picked up the new naming convention and stopped prefixing with _area/zone_name

@BWilky
Copy link

BWilky commented Feb 9, 2024

Reverted back to 24.1.5 confirming works without issue with previous naming convention

@jmayzurk
Copy link

jmayzurk commented Feb 9, 2024 •
edited

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

@joostlek
Copy link
Member

joostlek commented Feb 9, 2024

Please take note that with the new naming (which is used in 400+ other integrations) you can rename devices and automatically rename all entities.

The fact that the word None is appended is strange, can you maybe open a separate issue?

@joostlek joostlek mentioned this issue Feb 9, 2024
Closed
@eleibzon
Copy link

eleibzon commented Feb 9, 2024

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

How did you rename these entities? They appear as read only and can’t be renamed.

@eleibzon
Copy link

Restored back to 2024.1.6 and all the names show up. Hope this bug will be fixed soon.

@MortenVinding
Copy link

Same problem here.
I only have 4 shades in my RadioRa2, and now they all show up as Unnamed device:
Screenshot 2024-02-10 at 15 17 38

My firmware is probably also quite old, but I can't upgrade because from what I understand, newer firmwares requires a Lutron installer account to program 🙄

There is no mention of the shades in config/.storage/core.entity_registry

Each of my 4 shades does have a uniq id in the attribute though:
"Lutron integration ID 10" (and 7, 11 and 12)

Renaming is also not possible because:
Screenshot 2024-02-10 at 15 24 16

Please let me know if there is anything I can help with (all though I'm not at programmer).

On an unrelated note. I have long gotten a lot of these in the log:

2024-02-10 15:25:38.962 ERROR (Thread-4) [pylutron] Uncaught exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/pylutron/__init__.py", line 178, in _main_loop
    line = t.read_until(b"\n", timeout=3)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/telnetlib.py", line 320, in read_until
    self.fill_rawq()
  File "/usr/local/lib/python3.12/telnetlib.py", line 528, in fill_rawq
    buf = self.sock.recv(50)
          ^^^^^^^^^^^^^^^^^^
TimeoutError: [Errno 110] Operation timed out
2024-02-10 15:25:38.964 WARNING (Thread-4) [pylutron] Disconnected

Apparently not causing any problems, but upon investigating it I stumbled upon the obsoletion of telnetlib.py:
https://docs.python.org/3/library/telnetlib.html

Deprecated since version 3.11, will be removed in version 3.13: The [telnetlib]> (https://docs.python.org/3/library/telnetlib.html#module-telnetlib) module is deprecated (see [PEP 594]> (https://peps.python.org/pep-0594/#telnetlib) for details and alternatives).

@awrede
Copy link
Contributor

awrede commented Feb 10, 2024

I am also seeing the "unnamed_device" issue with the lights on my QS . Prior to 2024.2 my Lutron entities were named using the area and name that is stored with Lutron QS controller, and the integration_id was available as an attribute. I can make debug logs available for startups of 2024.1 and 2024.2, if that helps.

@kbed72
Copy link

kbed72 commented Feb 10, 2024

Just confirming seeing the exact same issues as the OP, and rolling back to 2024.1.5 restored it for me. I unfortunately don't have access to the RadioRA2 Inclusive software, which is required as a I have two repeaters in my setup, so hoping this can be fixed with needing to do any trickery using that software.

@cdheiser
Copy link
Contributor

cdheiser commented Feb 10, 2024 via email

@kbed72
Copy link

kbed72 commented Feb 10, 2024

DbXmlInfo.zip

Adding my config.

@awrede
Copy link
Contributor

awrede commented Feb 11, 2024

DbXmlInfo.zip

Here is mine

@BWilky
Copy link

BWilky commented Feb 11, 2024

Just confirming seeing the exact same issues as the OP, and rolling back to 2024.1.5 restored it for me. I unfortunately don't have access to the RadioRA2 Inclusive software, which is required as a I have two repeaters in my setup, so hoping this can be fixed with needing to do any trickery using that software.

https://www.reddit.com/r/Lutron/comments/12ctcgv/psa_lutron_now_allows_homeowners_to_do_radiora2/?share_id=T7Y3kN1mYq-H-vNoNH47E&utm_content=1&utm_medium=ios_app&utm_name=ioscss&utm_source=share&utm_term=1

Still works, scroll down to bottom of curl response. Literally just upgraded

@cdheiser
Copy link
Contributor

cdheiser commented Feb 11, 2024 via email

@wilburCforce wilburCforce mentioned this issue Feb 12, 2024
Merged
20 tasks
@kbed72
Copy link

kbed72 commented Feb 13, 2024

Wanted to provide an update on my end. Following the post that @BWilky provided, I was able to install and register RadioRa2 Inclusive and upgrade my Main Repeater firmware to the latest version. I rolled forward to the latest version of HA to see if the firmware upgrade solved the issue with entities being named wrong... and tadaaa, it did! I can confirm the issue is resolve with the firmware upgrade.

@cdheiser
Copy link
Contributor

cdheiser commented Feb 13, 2024 via email

@wilburCforce wilburCforce mentioned this issue Feb 14, 2024
Merged
20 tasks
@wilburCforce
Copy link
Contributor

I've put together a fix for the UUID issue. Unfortunately, returning to the old naming of entities does not look like it is possible with the introduction of the devices. Entity naming follows the device name and if you add the area_device to the entity name the resultant friendly name also incorporates the device name. So you end up with device_area_device which is a mess. If we change the device name to area_device then you have a lot of garbage data since the area is a separate attribute on a device. So I think we just need to move into the future for this part of it.

The PR noted above will address the uuid with the legacy uuid cdheiser added in pylutron 2.12. If you update your firmware to a later version it will update the identifiers as well to make the transition seamless. For users that already have naming in place, this change won't result in any changes. It comes into play when you add the integration fresh.

For users that rolled back to 2024.1, you will still end up with new entities once this is implemented but the naming will be correct and that should be the last time you have this happen. There's just no clean way to update and identify these otherwise at this point.

@eleibzon
Copy link

eleibzon commented Feb 20, 2024 •
edited

I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder.

After restart I get the following error in the logs:

The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

any ideas much appreciated.

@wilburCforce
Copy link
Contributor

I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder.

After restart I get the following error in the logs:

The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

any ideas much appreciated.

The update to pylutron 2.12 to support this issue was delivered in 2024.2.2.
The corresponding fix in Home Assistant noted above ( #110524 ) has been accepted and merged into the dev branch and is currently tagged for release with 2024.2.3 which I would anticipate in the next week or so. Watch the release notes to see if it was included before you update.

@cdheiser
Copy link
Contributor

cdheiser commented Feb 20, 2024 via email

@wilburCforce
Copy link
Contributor

you need to add a version to the manifest.json like this: "version": "1.0.0"
…
On Tue, Feb 20, 2024 at 1:01 PM wilburCforce @.> wrote: I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder. After restart I get the following error in the logs: The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details any ideas much appreciated. The update to pylutron 2.12 to support this issue was delivered in 2024.2.2. The corresponding fix in Home Assistant noted above ( #110524 <#110524> ) has been accepted and merged into the dev branch and is currently tagged for release with 2024.2.3 which I would anticipate in the next week or so. Watch the release notes to see if it was included before you update. — Reply to this email directly, view it on GitHub <#110038 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWX76EJMXGH6SAJVBR3YUUFJDAVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGA4TAMZYGU . You are receiving this because you were mentioned.Message ID: @.>

The versions are handled by automation. That's a placeholder.

@jschafermo
Copy link

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

I updated to 2024.2.2 from 2024.1.x and have this same issue with "None" being added to the end of the name in Home Assistant. If the Lutron entity is a light entity, "None" is not added. If a switch entity, "None" is added. Not sure where "None" is coming from, any suggestions?

Thanks

@wilburCforce
Copy link
Contributor

I updated to 2024.2.2 from 2024.1.x and have this same issue with "None" being added to the end of the name in Home Assistant. If the Lutron entity is a light entity, "None" is not added. If a switch entity, "None" is added. Not sure where "None" is coming from, any suggestions?

This will be my final response to folks that don't read this issue for the answers. The fix for pylutron is in 2024.2 and the fix for the home assistant Lutron component is scheduled for 2024.3 which is not yet released. Please read the comments above for more information.

@jschafermo
Copy link

I updated to 2024.2.2 from 2024.1.x and have this same issue with "None" being added to the end of the name in Home Assistant. If the Lutron entity is a light entity, "None" is not added. If a switch entity, "None" is added. Not sure where "None" is coming from, any suggestions?

This will be my final response to folks that don't read this issue for the answers. The fix for pylutron is in 2024.2 and the fix for the home assistant Lutron component is scheduled for 2024.3 which is not yet released. Please read the comments above for more information.

The last comment I read concerning "None" being added was concerning it being strange and later how to edit. I didn't realize 2024.3 would address "None" issue. Read [area] [device name] being addressed with future update, but thought I had an error causing "None" to be added.

@wilburCforce
Copy link
Contributor

@jschafermo sorry I bit your head off.
2024.2.3 is now released and should resolve the issues in this thread including the None issue.
If you are on older firmware of Lutron that doesn't have UUIDs then this will likely create a new set of entities for you. This is a one time pain however as the entities will then have a unique identifier moving forward and if you do upgrade to firmware with the UUID the integration will migrate those for you. For folks that had issues, please let us know if it is now resolved with 2024.2.3

@jschafermo
Copy link

@jschafermo sorry I bit your head off. 2024.2.3 is now released and should resolve the issues in this thread including the None issue. If you are on older firmware of Lutron that doesn't have UUIDs then this will likely create a new set of entities for you. This is a one time pain however as the entities will then have a unique identifier moving forward and if you do upgrade to firmware with the UUID the integration will migrate those for you. For folks that had issues, please let us know if it is now resolved with 2024.2.3

No worries!

I installed 2024.2.3 earlier today, but still have the "None" issue if the entity is a switch entity, but not with a light entity. I have mainly Lutron dimmers, but a few on/off switches. When I added Lutron to HA, dimmers were created as light entities and switches were created as switch entities. I'm using Lutron Essentials 12.10.0,

Don't know if this helps, but I can eliminate "None" from being added to switch devices, Back Yard Floodlight in this example, by naming the entity created under Controls when the device is selected. When the switch is opened, "None" is added to the device name. This doesn't happen for light devices, in this example Bar Lights. I've attached a few screen captures hoping it may help.

Appreciate all the help!

HA

HA

HA

HA

HA

@MarkzP
Copy link
Author

MarkzP commented Feb 24, 2024

In my case, the fix for older firmware without UUIDs fixed the root cause - I did have to rename a few switches (not sure where this none is coming from), but now I can fully manage them as first class HA entities
Greatly appreciated, thanks!

@wilburCforce
Copy link
Contributor

For someone still seeing the "None" issue on switches, could you post your db xml file from your lutron repeater? I don't see any reason why the switch entity would do that and not the light entity so I'd like to mock it up and recreate the issue.

@wilburCforce
Copy link
Contributor

I was able to recreate the none issue and I think I've narrowed it down to an attr issue. My best guess is that this is a bug in the core switch component of home assistant itself. This is going to take some more digging.

@wilburCforce
Copy link
Contributor

I found the bug for the None. It is in the Lutron integration and is a one line fix. I'll get a PR whipped up this weekend for it.

@jschafermo
Copy link

I found the bug for the None. It is in the Lutron integration and is a one line fix. I'll get a PR whipped up this weekend for it.

Thanks!

@wilburCforce
Copy link
Contributor

The "none" bug should be resolved with #111293
Currently it is tagged to release with 2024.2.4 which I'd expect in the next couple of days.

@wkearney99
Copy link

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

I have run into the same problem with devices appended with 'none'?

What's the path to step back from this?

@BWilky
Copy link

BWilky commented Feb 25, 2024 via email

@wilburCforce
Copy link
Contributor

wilburCforce commented Feb 25, 2024 •
edited

I have run into the same problem with devices appended with 'none'?

What's the path to step back from this?

@wkearney99 see #111293
should be released in the next couple of days. Roll back to your working HA version for the moment

@wilburCforce
Copy link
Contributor

@BWilky and anyone else interested in the area prefix for entities, let's discuss the options over here: #110034

@jschafermo
Copy link

The "none" bug should be resolved with #111293 Currently it is tagged to release with 2024.2.4 which I'd expect in the next couple of days.

Updated to 2024.2.4, I no longer have the 'None" issue.

Thanks

@wilburCforce
Copy link
Contributor

@home-assistant close

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
integration: lutron
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests