Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set Water Heater to climate mode HEAT #112587

Closed
WhimsyP opened this issue Mar 7, 2024 · 33 comments · Fixed by #112686
Closed

Unable to set Water Heater to climate mode HEAT #112587

WhimsyP opened this issue Mar 7, 2024 · 33 comments · Fixed by #112686

Comments

@WhimsyP
Copy link

WhimsyP commented Mar 7, 2024

The problem

Since ha core v2024.3.0, it is no longer possible to set the climate mode to HEAT for a Water Heater. It is still possible to set it to Off and Auto. This functionality worked as recently as v2024.2.5.

After setting to Heat, the option reverts to the previous setting after a few seconds. There are no errors or warnings in the log.

Log snippet for all climate settings below:

Heat (not working):

2024-03-07 08:13:27.949 DEBUG (SyncWorker_60) [homeassistant.components.tado.water_heater] Switching to HEAT for zone Hot Water (0) with temperature 5
2024-03-07 08:13:27.949 DEBUG (SyncWorker_60) [homeassistant.components.tado] Set overlay for zone 0: overlay_mode=NEXT_TIME_BLOCK, temp=5, duration=None, type=HOT_WATER, mode=None fan_speed=None swing=None
2024-03-07 08:13:28.179 DEBUG (SyncWorker_60) [homeassistant.components.tado] Updating zone 0
2024-03-07 08:13:28.235 DEBUG (SyncWorker_60) [homeassistant.components.tado] Dispatching update to 292612 zone 0: <PyTado.zone.TadoZone object at 0x7f3258012b40>
2024-03-07 08:13:28.236 DEBUG (MainThread) [homeassistant.components.tado.water_heater] Updating water_heater platform for zone 0

Auto (working):

2024-03-07 08:15:55.644 DEBUG (SyncWorker_29) [homeassistant.components.tado.water_heater] Switching to SMART_SCHEDULE for zone Hot Water (0)
2024-03-07 08:15:55.718 DEBUG (SyncWorker_29) [homeassistant.components.tado] Updating zone 0
2024-03-07 08:15:55.772 DEBUG (SyncWorker_29) [homeassistant.components.tado] Dispatching update to 292612 zone 0: <PyTado.zone.TadoZone object at 0x7f3262521250>
2024-03-07 08:15:55.773 DEBUG (MainThread) [homeassistant.components.tado.water_heater] Updating water_heater platform for zone 0

Off (working):

2024-03-07 08:15:36.477 DEBUG (SyncWorker_48) [homeassistant.components.tado.water_heater] Switching to OFF for zone Hot Water (0)
2024-03-07 08:15:36.594 DEBUG (SyncWorker_48) [homeassistant.components.tado] Updating zone 0
2024-03-07 08:15:36.706 DEBUG (SyncWorker_48) [homeassistant.components.tado] Dispatching update to 292612 zone 0: <PyTado.zone.TadoZone object at 0x7f325284fd70>
2024-03-07 08:15:36.706 DEBUG (MainThread) [homeassistant.components.tado.water_heater] Updating water_heater platform for zone 0

What version of Home Assistant Core has the issue?

core-2024.3.0

What was the last working version of Home Assistant Core?

core-2024.2.5

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Tado

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tado/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

(See summary)

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2024

Hey there @chiefdragon, @erwindouna, mind taking a look at this issue as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tado can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign tado Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


tado documentation
tado source
(message by IssueLinks)

@WhimsySpoon
Copy link

Possibly related to #111918

@timdonovanuk
Copy link

Same for me, no hot water this morning D:

@KingofCurrywurst
Copy link

It has worked without any problems for a year since yesterday I had to deactivate all tado automations.
Now I hope the error will be identified and fixed soon.

@timdonovanuk
Copy link

I've rolled back to 2024.2.5 in the meantime, no issue with that.

@WhimsySpoon
Copy link

I've downloaded the Tado code from the 2024.2.x release and am running it as a custom component in HA Core 2024.3.0 and it's working fine.

@erwindouna
Copy link
Contributor

I will provide a fix shortly. The issue is known.

@WhimsySpoon
Copy link

Unfortunately the issue wasn't fixed. The Hot Water can now be changed from auto and off, but the heat option is still broken.

Logs when selecting heat:

2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado.water_heater] Switching to HEAT for zone Hot Water (0) with temperature 5
2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado] Set overlay for zone 0: overlay_mode=NEXT_TIME_BLOCK, temp=5, duration=None, type=HOT_WATER, mode=None fan_speed=None swing=None
2024-03-14 18:37:09.195 DEBUG (SyncWorker_49) [homeassistant.components.tado] Updating zone 0
2024-03-14 18:37:09.261 DEBUG (SyncWorker_49) [PyTado.zone] Processing data from zone 0
2024-03-14 18:37:09.261 DEBUG (SyncWorker_49) [homeassistant.components.tado] Dispatching update to 292612 zone 0: <PyTado.zone.TadoZone object at 0x7f43be884c20>
2024-03-14 18:37:09.262 DEBUG (MainThread) [homeassistant.components.tado.water_heater] Updating water_heater platform for zone 0

@erwindouna
Copy link
Contributor

Unfortunately the issue wasn't fixed. The Hot Water can now be changed from auto and off, but the heat option is still broken.

Logs when selecting heat:

2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado.water_heater] Switching to HEAT for zone Hot Water (0) with temperature 5
2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado] Set overlay for zone 0: overlay_mode=NEXT_TIME_BLOCK, temp=5, duration=None, type=HOT_WATER, mode=None fan_speed=None swing=None
2024-03-14 18:37:09.195 DEBUG (SyncWorker_49) [homeassistant.components.tado] Updating zone 0
2024-03-14 18:37:09.261 DEBUG (SyncWorker_49) [PyTado.zone] Processing data from zone 0
2024-03-14 18:37:09.261 DEBUG (SyncWorker_49) [homeassistant.components.tado] Dispatching update to 292612 zone 0: <PyTado.zone.TadoZone object at 0x7f43be884c20>
2024-03-14 18:37:09.262 DEBUG (MainThread) [homeassistant.components.tado.water_heater] Updating water_heater platform for zone 0

Thanks for notifying. I will further investigate. Please do create a new issue, since I can work on that a new reference point.

@erwindouna
Copy link
Contributor

Unfortunately the issue wasn't fixed. The Hot Water can now be changed from auto and off, but the heat option is still broken.

Logs when selecting heat:

2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado.water_heater] Switching to HEAT for zone Hot Water (0) with temperature 5
2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado] Set overlay for zone 0: overlay_mode=NEXT_TIME_BLOCK, temp=5, duration=None, type=HOT_WATER, mode=None fan_speed=None swing=None
2024-03-14 18:37:09.195 DEBUG (SyncWorker_49) [homeassistant.components.tado] Updating zone 0
2024-03-14 18:37:09.261 DEBUG (SyncWorker_49) [PyTado.zone] Processing data from zone 0
2024-03-14 18:37:09.261 DEBUG (SyncWorker_49) [homeassistant.components.tado] Dispatching update to 292612 zone 0: <PyTado.zone.TadoZone object at 0x7f43be884c20>
2024-03-14 18:37:09.262 DEBUG (MainThread) [homeassistant.components.tado.water_heater] Updating water_heater platform for zone 0

Would you be willing to test the following Gist via a custom_component if you can? I am no owner myself of a water heater and I would require a friendly user to help out. :)

@erwindouna
Copy link
Contributor

Side question, are you actually setting the temperature to 5? It see it might use the default 5.

@WhimsySpoon
Copy link

Testing the Gist now...

To answer your question, I'm not setting the temp at all, just setting the mode to heat. The UI (and my boiler) doesn't support a temperature setting.

This is what the UI looks like:

image

Looking at the logs, shouldn't mode be heat?

2024-03-14 18:37:09.162 DEBUG (SyncWorker_49) [homeassistant.components.tado] Set overlay for zone 0: overlay_mode=NEXT_TIME_BLOCK, temp=5, duration=None, type=HOT_WATER, mode=None fan_speed=None swing=None

@erwindouna
Copy link
Contributor

Thanks for clarifying it this quickly! I think that brings me to the conclusion, that the default settings should be adjusted. I'll provide a new Gist a bit later on (maybe tomorrow at latest).

@WhimsySpoon
Copy link

Great, thank you!

FYI, that Gist failed to load with an import error:

Logger: homeassistant.config_entries
Source: config_entries.py:482
First occurred: 21:40:08 (1 occurrences)
Last logged: 21:40:08

Error importing platform config_flow from integration tado to set up tado configuration entry: cannot import name 'ConfigFlowResult' from 'homeassistant.config_entries' (/usr/src/homeassistant/homeassistant/config_entries.py)

I'm not sure if I'm loading it correctly, but I grabbed the tado folder from the Core repo and downloaded it into a custom_components directory and replaced (and renamed) the file from your Gist,

@erwindouna
Copy link
Contributor

Great, thank you!

FYI, that Gist failed to load with an import error:

Logger: homeassistant.config_entries
Source: config_entries.py:482
First occurred: 21:40:08 (1 occurrences)
Last logged: 21:40:08

Error importing platform config_flow from integration tado to set up tado configuration entry: cannot import name 'ConfigFlowResult' from 'homeassistant.config_entries' (/usr/src/homeassistant/homeassistant/config_entries.py)

I'm not sure if I'm loading it correctly, but I grabbed the tado folder from the Core repo and downloaded it into a custom_components directory and replaced (and renamed) the file from your Gist,

Would you happen to know the specifications what the minimum and maximum temperature ranges are of your water heater?

@WhimsySpoon
Copy link

WhimsySpoon commented Mar 14, 2024

It doesn't have a range. It's either on or off. I'm not using a combi boiler; mine fills a hot water tank. When the hot water control is on, it opens a zone valve and calls for heat from the boiler.

I'm using this Tado product to do so: https://uk.shop.tado.com/products/wireless-receiver

I think Tado do sell a version that uses the opentherm spec to specify a temperature, but this one doesn't.

@erwindouna
Copy link
Contributor

Fully clear. I know what to adjust. For now I will revert the code and later on patch it properly. Thanks for sharing the information!

@WhimsySpoon
Copy link

Thank you for your efforts and assistance on this. More than happy to help in testing any changes, providing logs etc.

@will-fezz
Copy link

I also have the same problem. I am not technically gifted but if you need help testing and can explain what to do I will be happy to assist.

Thanks for all your help and I appreciate the work.

@arwindersingh82
Copy link

I also have the same issue. Happy to offer any support or test any fixes if required too :).

Thank you for all the work :)

@pwhitea
Copy link

pwhitea commented Mar 15, 2024

@erwindouna Will this be reverted in the next release?

@erwindouna
Copy link
Contributor

@erwindouna Will this be reverted in the next release?

That's the idea, that code quality improvements specifically for the water heater will be reverted. In another PR I will work on the code quality again. A PR is already under review for this particular reversal.

@samnewman86
Copy link

Thanks, also happy to test. Anything to avoid another cold shower

@timdonovanuk
Copy link

timdonovanuk commented Mar 20, 2024

I'm confused, I thought this was fixed and released in 2024.3.1 but I upgraded today and just had a cold shower. Same issue where I cannot toggle on the climate mode to HEAT for a Water Heater (reverts back to OFF within seconds). This ticket is the one referenced by the PR which is documented as part of 2024.3.1.

https://www.home-assistant.io/blog/2024/03/06/release-20243/#release-202431---march-14:~:text=Fix%20tado%20climate%20service

@WhimsyP
Copy link
Author

WhimsyP commented Mar 21, 2024

A fix was released in 2024.3.1, unfortunately it didn't fix the water heater issue (this one).

The changes in 2024.3.0 are going to be reverted (fixed) in 2024.3.2.

@arwindersingh82
Copy link

do we know when this revert (fix) will be available?

@WhimsyP
Copy link
Author

WhimsyP commented Mar 21, 2024

The fix was merged yesterday and is tagged for the 2024.3.2 release. It should be available soon.

#113464

@erwindouna
Copy link
Contributor

The fix was merged yesterday and is tagged for the 2024.3.2 release. It should be available soon.

#113464

It shouldn't take long before patch 2024.3.2 will be released. :)

@timdonovanuk
Copy link

Ah thank you all, appreciated! :)

@WhimsyP
Copy link
Author

WhimsyP commented Mar 22, 2024

Have just installed HA Core 2024.3.2 and can confirm this issue is now resolved. Thanks to everyone involved for helping.

@erwindouna
Copy link
Contributor

Have just installed HA Core 2024.3.2 and can confirm this issue is now resolved. Thanks to everyone involved for helping.

Thanks for confirming! Great to see it's resolved properly now!

@WhimsyP
Copy link
Author

WhimsyP commented Mar 22, 2024

@erwindouna Please don't let this put you off future refactors and improvements of this integration. I'm incredibly grateful for the work you and others do on this. I'd be more than happy to test future changes in a beta or a custom_component - please just reach out.

@erwindouna
Copy link
Contributor

@erwindouna Please don't let this put you off future refactors and improvements of this integration. I'm incredibly grateful for the work you and others do on this. I'd be more than happy to test future changes in a beta or a custom_component - please just reach out.

That's very much appreciated, thanks. I'll keep this in mind for future features, where I need a friendly user with a water heater. ;)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants