New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tado climate service #112686
Fix tado climate service #112686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @chiefdragon, @erwindouna, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Looks like I can't sign the CLA as the Home Assistant Github OAuth app integration has reached the rate limit, seeing The rate limit seems to reset at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're very swift in providing a solution. Many thanks and good work @alinbalutoiu!
Can you also link #112587? This will auto-close the issue once it's merged by a Core Member. |
Sure, I've linked it as well 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comment in a new PR. Thanks!
This issue persists in 2024.3.1 for me. Will detail in the linked issue #112587 |
Breaking change
Proposed change
Fixes a bug in the Tado set climate service which has broken recently: https://github.com/home-assistant/core/pull/107678/files#diff-5a805908fe968cc52b6a08f2e87e981d565d3990d762c770b10980fe74f88641L392-R407
All parameters were optionals, but they've been made required and it causes the service to fail. More details about the failure in #111918
I have tested it locally ony my server and works fine.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: