Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ZWave config files via service call zwave.update_config does not actually work #19893

Closed
kpine opened this issue Jan 9, 2019 · 10 comments · Fixed by #25959
Closed

Comments

@kpine
Copy link
Contributor

kpine commented Jan 9, 2019

Home Assistant release with the issue:

0.84.5

Last working Home Assistant release (if known):
I don't think it ever worked.

Operating environment (Hass.io/Docker/Windows/etc.):

Virtualenv on Debian 9.

Component/platform:

zwave

Description of problem:

The recommend method to update the OpenZWave device configuration files has been to run the zwave.update_config service call, which downloads the latest OpenZWave source code from github and copies the config files into the OpenZWave config path. It is really just a wrapper around a python-openzwave API. Until recently that API was broken, so this service call likely never functioned as desired.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
N/A

Traceback (if applicable):
N/A

Additional information:
The issue has been fixed in the upstream python-openzwave project. The fixes need to be added to the HA fork.

Upstream Issue: OpenZWave/python-openzwave#156
Commits: OpenZWave/python-openzwave@3ef3e4b and OpenZWave/python-openzwave@82e1f33

@pdobrien3
Copy link

This is affecting me now as one of the devices in my zwave network is being properly recognized because of an old manufacturer_specific.xml. Last time I tried to use the zwave.update_config it created a new config folder in the ozw_config folder and proceeded to place all the device specific files in the new folder. Would be very nice to be able to quickly update the OZW device files prior to installing a new device and have it properly update. Very similar to apt-get update.

@zipperten
Copy link

I think it works on hassbian, the config files restores in my config folder. My friend that run hass.io have this bug!

@kpine
Copy link
Contributor Author

kpine commented Mar 14, 2019

Look in your config folder, you probably have another config folder inside.

@zipperten
Copy link

kpine, you are right! one ozw_config and one config.
/srv/homeassistant/lib/python3.5/site-packages/python_openzwave/ozw_config/config

@kpine
Copy link
Contributor Author

kpine commented Mar 22, 2019

Why was this closed? Has it been fixed?

@robbiet480
Copy link
Member

@kpine Sorry, maybe I misread the recent comments. I thought you identified a fix by ensuring that only one config folder exists. If I was incorrect I'll reopen!

@kpine
Copy link
Contributor Author

kpine commented Mar 22, 2019

Sorry, I wasn't clear. My comment meant that the problem still exists.

@robbiet480
Copy link
Member

Not a problem, thanks for confirming!

@robbiet480 robbiet480 reopened this Mar 22, 2019
@Autoxx
Copy link

Autoxx commented Apr 6, 2019

I have the same error on NAS Synology. I use a docker.

/usr/local/lib/python3.7/site-packages/python_openzwave/ozw_config/ and inside antother config folder.

@kpine
Copy link
Contributor Author

kpine commented May 4, 2019

I'm closing this issue since there's been no action for 4 months. Anyone with this problem should just manage the config files on your own instead of using update_config.

In fact, merging the upstream fixes now will actually cause a bigger problem now that 1.6 has been released. The OZW master branch, where the update_config service downloads files from, now contains all the 1.6 code along with new XML files that are incompatible with 1.4. Unless python-openzwave or the HA fork update it to use the 1.4 branch instead, the wrong config files will be downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment