Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Apply upstream fix for zwave.update_config directory name and double-definition #4

Closed
wants to merge 1 commit into from
Closed

Conversation

smockle
Copy link

@smockle smockle commented May 21, 2019

Second attempt (following #3):

Fixes home-assistant/core#19893

Upstream issue: OpenZWave#156
Upstream commits: OpenZWave@3ef3e4b and OpenZWave@82e1f33

Also attempts to address @kpine’s comment in home-assistant/core#19893 (comment):

In fact, merging the upstream fixes now will actually cause a bigger problem now that 1.6 has been released. The OZW master branch, where the update_config service downloads files from, now contains all the 1.6 code along with new XML files that are incompatible with 1.4. Unless python-openzwave or the HA fork update it to use the 1.4 branch instead, the wrong config files will be downloaded.

@smockle
Copy link
Author

smockle commented May 21, 2019

The Travis CI build for this PR failed, but in fact there has never been a passing build of Home Assistant’s python-openzwave fork: https://travis-ci.com/home-assistant/python-openzwave/builds

======================================================================
FAIL: test_000_init (tests.lib.autobuild.test_lib.TestInit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pyozw/tests/lib/autobuild/test_lib.py", line 46, in test_000_init
    self.assertEqual(manager.getPythonLibraryVersionNumber(), pyozw_version)
AssertionError: '0.4.19' != '0.1.4'
- 0.4.19
+ 0.1.4

@smockle
Copy link
Author

smockle commented May 29, 2019

cc @pvizeli Are you aware that Travis CI builds have never succeeded (see comment above)?

@smockle
Copy link
Author

smockle commented Jul 12, 2019

Three months have passed since I opened #3. Closing due to inactivity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants