Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Component tplink unable to import" Travis CI config file checking broken in 0.94.4 worked in 0.94.3 #24720

Closed
shortbloke opened this issue Jun 23, 2019 · 5 comments · Fixed by #25005

Comments

@shortbloke
Copy link
Contributor

shortbloke commented Jun 23, 2019

Home Assistant release with the issue: 0.94.4

Last working Home Assistant release (if known): 0.94.3

Operating environment (Hass.io/Docker/Windows/etc.):
Travis CI - Xenial - Python 3.6 and 3.7

Component/platform:
tplink

Description of problem:
I use TravisCI as part of ensuring my published configuration is fully working. As of 0.94.4 this has broken with an error for each of my packages which contain the tplink component, "component tplink unable to import"

 homeassistant.packages.appliance_dryer.tplink: 
    - Package appliance_dryer setup failed. Component tplink unable to import

Final output from Travis

Successful config (partial)
  homeassistant.packages.appliance_dishwasher.tplink:
  homeassistant.packages.appliance_dryer.tplink:
  homeassistant.packages.appliance_irons.tplink:
  homeassistant.packages.appliance_washingmachine.tplink:
The command "hass -c . --script check_config" exited with 4.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
I am using packages/.yaml example from packages\appliance_dryer.yaml

##################################################
## Components/Sensors
##################################################
tplink:
  switch:
    - host: 192.168.200.28 # DHCP reservation

sensor:
  - platform: template
    sensors:
      tumble_dryer_power:
        value_template: "{{ states.switch.tumble_dryer.attributes['current_power_w'].split(' ')[0] }}"
        unit_of_measurement: 'W'
        friendly_name: "Tumble Dryer Power"
      tumble_dryer_power_today:
        value_template: "{{ states.switch.tumble_dryer.attributes['today_energy_kwh'] | float | round(2) }}"
        unit_of_measurement: 'kWh'
        friendly_name: "Tumble Dryer Power Today"

.travis.yml

dist: xenial   # required for Python >= 3.7
language: python
python:
  - "3.6"
  - "3.7"
before_install:
  - mv travis/travis_secrets.yaml secrets.yaml
  - mv travis/travis.fake_ssl_crt travis.fake_ssl_crt
  - mv travis/travis.fake_ssl_key travis.fake_ssl_key
  - sudo apt-get install -y libudev-dev
install:
  - pip3 install homeassistant
script:
  - hass -c . --script check_config

Additional information:
Have also tried latest dev branch, which has the same issue.

@shortbloke
Copy link
Contributor Author

Still broken in 0.95.4

@lociii
Copy link
Contributor

lociii commented Jun 29, 2019

Same here. Works perfectly fine on my docker based installation at home but fails on travis.

# python -m homeassistant --config /config --script check_config
Testing configuration at /config
#

https://travis-ci.org/lociii/homeassistant-config

@CCOSTAN
Copy link
Contributor

CCOSTAN commented Jul 16, 2019

Still seems to be an issue with TPLINK with 0.95.4

https://travis-ci.org/CCOSTAN/Home-AssistantConfig/jobs/559689872#L576-L577

@shortbloke
Copy link
Contributor Author

@CCOSTAN That's expected the change was merged to dev 10 days ago (7 July). 19.4 was released on 28 June.
So we just need to await the next release to pick up the change.

@CCOSTAN
Copy link
Contributor

CCOSTAN commented Jul 17, 2019

Aah! Perfect. I wasn't sure how this was incorporated into the release cycle since it was travis. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants