Install requirements for integrations in packages before importing them. #25005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this might solve the unifi device tracker issue as well. It works if a config entry exists but else it will fail with a similar message |
balloob
approved these changes
Jul 7, 2019
KJonline
pushed a commit
to Rendili/home-assistant
that referenced
this pull request
Jul 8, 2019
… into hive_water_heater * 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits) Sensibo, add HVAC_MODE_OFF (home-assistant#25016) Add support for arcam fmj receivers (home-assistant#24621) Enphase envoy individual inverter production (home-assistant#24445) Implement Twilio SMS notify MediaUrl support (home-assistant#24971) Climate 1.0 (home-assistant#23899) Correct socket use in cert_expiry platform (home-assistant#25011) Added missing yeelight models mapping (home-assistant#24963) Install requirements for integrations in packages before importing them. (home-assistant#25005) Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765) Upgrade hdate==0.8.8 (home-assistant#25008) upgrade switchmate to latest lib (home-assistant#25006) Test dependency updates (home-assistant#25004) Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809) Sleepiq single sleeper crash (home-assistant#24941) Changes as per code review of home-assistant#24646 (home-assistant#24917) Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998) Adds Stale Probot for issues (home-assistant#24985) Adds Lock Threads Probot (home-assistant#24984) Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821) Fix errors if rest source becomes unavailable (home-assistant#24986) ... # Conflicts: # homeassistant/components/hive/__init__.py # homeassistant/components/hive/climate.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change will install the requirements of integrations (if any) before trying to import it.
If the integration import has imports from external packages in the top (not in a function/method) you will get this error on config_check and startup if the configuration for that integration is in a package instead of directly in configuration,yaml:
Related issue (if applicable): fixes #24954 fixes #24720
There is also an issue with Yellight could not find a related issue for it but it was reported in #devs_general
After the move to manifest.json for requirements, more and more integrations will start to get this issue as well.
Checklist:
tox. Your PR cannot be merged unless tests passTravis and CircleCI passed in my fork.