Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IKEA Tradfri #26863

Closed
6 of 7 tasks
ggravlingen opened this issue Sep 23, 2019 · 4 comments
Closed
6 of 7 tasks

Refactor IKEA Tradfri #26863

ggravlingen opened this issue Sep 23, 2019 · 4 comments
Labels

Comments

@ggravlingen
Copy link
Contributor

ggravlingen commented Sep 23, 2019

As I was adding support for the Tradfri blinds, I realized there is a lot of repeated code in the different files of the Tradfri lib. This is an issue to hold together refactoring of the code.

To-do:

@SqyD
Copy link
Contributor

SqyD commented Oct 7, 2019

While you're at it, may I drop in a feature request to have the sensors be displayed with Battery icons and properties?

@ggravlingen
Copy link
Contributor Author

They had a battery icon when I tested the new code yesterday so I believe I've implemented what you request 😊

@ggravlingen
Copy link
Contributor Author

@SqyD looks like the batteries didn’t make it to version 100 so they’ll be there in 101.

@stale
Copy link

stale bot commented Jan 19, 2020

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue now has been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 19, 2020
@stale stale bot closed this as completed Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants