Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tradfri light #27259

Merged
merged 2 commits into from Oct 7, 2019
Merged

Refactor tradfri light #27259

merged 2 commits into from Oct 7, 2019

Conversation

ggravlingen
Copy link
Contributor

@ggravlingen ggravlingen commented Oct 6, 2019

Description:

This is a continuation of the refactoring of the Tradfri library. This PR regards the light file.

Related issue (if applicable): relates to #26863

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Oct 6, 2019
@ggravlingen ggravlingen changed the title Refactor light file Tradfri: refactor light file Oct 6, 2019
@MartinHjelmare MartinHjelmare changed the title Tradfri: refactor light file Refactor tradfri light Oct 6, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 6, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@balloob balloob merged commit fe155fa into home-assistant:dev Oct 7, 2019
Dev automation moved this from Reviewer approved to Done Oct 7, 2019
@lock lock bot locked and limited conversation to collaborators Oct 8, 2019
@ggravlingen ggravlingen deleted the refactortradfri3 branch October 13, 2019 09:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants