Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device action support to the media_player integration #26990

Closed
balloob opened this issue Sep 27, 2019 · 8 comments
Closed

Add device action support to the media_player integration #26990

balloob opened this issue Sep 27, 2019 · 8 comments
Labels
Hacktoberfest help-wanted Wanna help? Jump in!

Comments

@balloob
Copy link
Member

balloob commented Sep 27, 2019

Add device action support to the media_player integration.

Device actions are part of Device Automations, a new concept that was recently launched to make automations more user friendly.

Device automations consist of three different parts: triggers, conditions and actions. This issue is about the action part.

To get started with this issue, you will need to set up a Home Assistant development environment. The easiest approach is to get started using a dev container.

Once you have a development environment set up, run the following and follow the instructions:

python3 -m script.scaffold device_action

(This issue is part of #26979)

@balloob balloob added Hacktoberfest help-wanted Wanna help? Jump in! labels Sep 27, 2019
@balloob balloob changed the title Add improved scene support to the media_player integration Add device action support to the media_player integration Sep 27, 2019
@manekenpix
Copy link

Can I work on this one for Hacktoberfest?

@balloob
Copy link
Member Author

balloob commented Oct 1, 2019

Yes. All issues marked as Hacktoberfest are up for grabs ! (well any issue really, but Hacktoberfest are preferred)

@manekenpix
Copy link

I ran into this issue while following this (using Setup local repository):

Traceback (most recent call last):
  File "/home/{user}/.local/bin/pre-commit", line 6, in <module>
    from pre_commit.main import main
ModuleNotFoundError: No module named 'pre_commit'

I installed pre-commit (pip3 install pre-commit), but no luck.

@emontnemery
Copy link
Contributor

emontnemery commented Oct 6, 2019

Please make sure to follow the instructions here: https://developers.home-assistant.io/docs/en/development_environment.html

With the error you see, you might have forgotten this step: https://developers.home-assistant.io/docs/en/development_environment.html#setting-up-virtual-environment

@springstan
Copy link
Member

@manekenpix any updates on this? :)

@timmo001
Copy link
Contributor

timmo001 commented Oct 1, 2020

A couple of good ones here that could be added for devices that support the features.

  • Volume (up, down, set, etc.)
  • Controls (play, pause, seek, shuffle, source, sound mode etc.)
  • Play Media (if integration loaded and supported)
  • Cast (might be specific to the cast integration though)

@chmielowiec
Copy link
Contributor

For reference: #35679

@balloob balloob closed this as completed Oct 16, 2020
@balloob
Copy link
Member Author

balloob commented Oct 16, 2020

Closing this as per #35679, we need more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help-wanted Wanna help? Jump in!
Projects
None yet
Development

No branches or pull requests

6 participants