Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device condition support to the calendar integration #26997

Open
balloob opened this issue Sep 27, 2019 · 6 comments
Open

Add device condition support to the calendar integration #26997

balloob opened this issue Sep 27, 2019 · 6 comments
Labels
Hacktoberfest help-wanted Wanna help? Jump in!

Comments

@balloob
Copy link
Member

balloob commented Sep 27, 2019

Add device condition support to the calendar integration.

Device conditions are part of Device Automations, a new concept that was recently launched to make automations more user friendly.

Device automations consist of three different parts: triggers, conditions and conditions. This issue is about the condition part.

To get started with this issue, you will need to set up a Home Assistant development environment. The easiest approach is to get started using a dev container.

Once you have a development environment set up, run the following and follow the instructions:

python3 -m script.scaffold device_condition

(This issue is part of #26994)

@balloob balloob added Hacktoberfest help-wanted Wanna help? Jump in! labels Sep 27, 2019
@manekenpix
Copy link

manekenpix commented Oct 1, 2019

I'll take this one for Hacktober fest if it's ok

@balloob
Copy link
Member Author

balloob commented Oct 1, 2019

Oh ha, I am actually thinking that this one was a mistake. As a calendar doesn't have devices 🙈

I do agree that a calendar should be able to have certain pre-made triggers ready. Hmmmzzzzz, I guess we do have AdGuard representing the service as a device, so we could do the same per calendar.

@balloob
Copy link
Member Author

balloob commented Oct 1, 2019

@manekenpix I think that it's fine to add this to the calendar integration 👍

Note that we don't have any calendar platforms right now that have devices.

@manekenpix
Copy link

@manekenpix I think that it's fine to add this to the calendar integration

Note that we don't have any calendar platforms right now that have devices.

Ok, I'll work on #26990 then

@github-actions
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jan 26, 2021
@adamweiss
Copy link

Hi, I can take this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help-wanted Wanna help? Jump in!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants