Logbook component broken after 72f336a (bisected)

[clapbr]

Home Assistant release with the issue: 0.104.0.dev0 (git)

Last working Home Assistant release (if known):

Operating environment (Hass.io/Docker/Windows/etc.):

Integration:

Description of problem:
Logbook doesn't load on current dev branch.

2019-12-11 10:19:14 ERROR (MainThread) [homeassistant.setup] Setup failed for logbook: Unable to import component
2019-12-11 10:19:14 ERROR (MainThread) [homeassistant.setup] Unable to set up dependencies of default_config. Setup failed for dependencies: logbook
2019-12-11 10:19:14 ERROR (MainThread) [homeassistant.setup] Setup failed for default_config: Could not set up all dependencies.

Since logs doesn't say much I bisected the culprit: 72f336a
Since the changes are rather small and look completely unrelated I tested reverting only the commit locally in a clean venv+clean config and logbook loaded normally with no other errors.

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

[clapbr]

@springstan, mind rechecking your PR ?

[springstan]

@clapbr sure I will take a look at it as soon as possible

[springstan]

I can confirm that 72f336a caused this issue. However, only this line: from .accessories import HomeBridge, HomeDriver causes this issue, moving it back into the setup function resolves the error completely.
Not really sure what is actually causing this error since this is unrelated to the logbook component.

[pnbruckner]

It appears the loading of logbook is broken again.

I was able to make a reproducible test case by doing a clean checkout of dev branch (84e1b3d), and then doing a clean venv (Python 3.7) install. I deleted everything from my config directory, then created configuration.yaml with just these lines:

frontend:
logbook:

Then running a config check I get:

hass --script check_config
Testing configuration at /home/phil/.homeassistant
INFO:homeassistant.util.package:Attempting install of home-assistant-frontend==20191204.1
INFO:homeassistant.util.package:Attempting install of aiohttp_cors==0.7.0
INFO:homeassistant.util.package:Attempting install of sqlalchemy==1.3.11
INFO:homeassistant.util.package:Attempting install of HAP-python==2.6.0
Failed config
  General Errors:
    - Component error: logbook - No module named 'PIL'

Successful config (partial)

After digging a bit I discovered that PIL is from the package named Pillow. That package is not getting installed. However if I run:

pip3 install -r requirements_test_all.txt -c homeassistant/package_constraints.txt

then it will now be installed & the config check succeeds.

It also succeeds if I start again and just have logbook: in configuration.yaml, or if I have default_config:.

[springstan]

@pnbruckner however installing pillow manually does not work for me. Still getting the same error you mentioned.

[balloob]

We should move the imports for homekit inside the function again in logbook.