New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup error for logbook #29908
Fix setup error for logbook #29908
Conversation
I do not know why the logbook fails to setup when the imports are at the top for the homekit integration. |
Logbook imports homekit constants. In Python, importing |
We shouldn't revert it but instead add It's annoying because really we should turn it around, have homekit register itself with logbook on how to render its events. |
@balloob okay thanks for the clarification on this issue, will close it now. |
It is probably the best to solve this error in one PR instead of splitting it into two and therefore I reopened this PR to solve this problem by adding homekit as a after dependency to logbook as suggested by @balloob. |
I've opened #29913 to better explain the issue and list things to solve to get to a solution. I will go ahead and approve this PR today because we can hot fix this to get 103 working. |
I did add it to the milestone but really that can only work if we can also include #29491 , so tagged that one too. |
Breaking Change:
Description:
Related issue (if applicable): fixes #29845
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: