Yeelight custom effects incomplete support

[jonwaland]

The problem

Yeelight integration lists RECOVER, STAY and OFF as options for a Flow ACTION. OFF isn't accepted and generates an error

Environment

• Home Assistant Core release with the issue: 0.107.7
• Last working Home Assistant Core release (if known):
• Operating environment (Home Assistant/Supervised/Docker/venv): vevnv
• Integration causing this issue: yeelight
• Link to integration documentation on our website: https://www.home-assistant.io/integrations/yeelight/

Problem-relevant configuration.yaml

  - name: 'WarmOnOff'
    flow_params:
      count: 1
      action: off
      transitions:
        - RGBTransition: [255, 255, 55, 50, 1]
        - TemperatureTransition: [1700, 10000, 10]

Traceback/Error logs

2020-04-16 09:37:43 ERROR (MainThread) [homeassistant.config] Invalid config for [yeelight]: not a valid value for dictionary value @ data['yeelight']['custom_effects'][3]['flow_params']['action']. Got False. (See /home/homeassistant/.homeassistant/configuration.yaml, line 235). Please check the docs at https://www.home-assistant.io/integrations/yeelight
2020-04-16 09:37:43 ERROR (MainThread) [homeassistant.setup] Setup failed for yeelight: Invalid config.

Additional information

arch	x86_64
dev	false
docker	false
hassio	false
os_name	Linux
os_version	4.4.0-173-generic
python_version	3.8.2
timezone	Australia/Sydney
version	0.107.7
virtualenv	true

[probot-home-assistant]

Hey there @rytilahti, @zewelor, mind taking a look at this issue as its been labeled with a integration (yeelight) you are listed as a codeowner for? Thanks!

[zewelor]

Hi

problem is that yaml interprets off as boolean, you need to quote it 'off'.

action: 'off'

https://yaml.org/type/bool.html

[jonwaland]

ahh. makes sense. shame the docs don't warn.

How do I propose a change to the text at https://www.home-assistant.io/integrations/yeelight/

along lines of

(note that off will need to be quoted in yaml ... 'off')

[zewelor]

Yes it would be better to state it there. You would need to make PR with this file changed. https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/yeelight.markdown . Documentation improvements are always welcome, and that off in yaml is confusing for sure :\

[jonwaland]

home-assistant/home-assistant.io#13024

[jonwaland]

PR rejected as too generic.