Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to integrate a ONVIF camera that requires an empty password #35904

Closed
apolselli opened this issue May 21, 2020 · 5 comments · Fixed by #36008
Closed

It is not possible to integrate a ONVIF camera that requires an empty password #35904

apolselli opened this issue May 21, 2020 · 5 comments · Fixed by #36008
Assignees

Comments

@apolselli
Copy link

The problem

It is not possible to integrate my ONVIF camera that requires an empty password.
The onvif yaml config is no more documented, so the onvif integration setup wizard from Lovelace should add support for this.
Also, the newly ONVIF dicovered integration can't be "ignored".

Environment

Home assistant on Raspberry Pi4.

  • Home Assistant Core release with the issue: 0.110
  • Last working Home Assistant Core release (if known):
  • Operating environment (Home Assistant/Supervised/Docker/venv): Home Assistant
  • Integration causing this issue: onvif
  • Link to integration documentation on our website: https://www.home-assistant.io/integrations/onvif/

Problem-relevant configuration.yaml

Traceback/Error logs

Additional information

@probot-home-assistant
Copy link

onvif documentation
onvif source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @hunterjm, mind taking a look at this issue as its been labeled with a integration (onvif) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@hunterjm
Copy link
Member

hunterjm commented May 21, 2020

ONVIF doesn't have a discovery flow, so it shouldn't show up with either "Configure" or "Ignore" buttons. You have to manually add it. Will look into allowing empty passwords... but that just sounds really bad. Are you sure your camera doesn't allow you to set one?

What is the Make/Model of the device?

@apolselli
Copy link
Author

apolselli commented May 22, 2020

The device is a Xiaovv Q8 HD 1080P 360°: it is a cheap camera that supports ONVIF with PTZ, but doesn't allow to change the password (empty) for the only user ("admin") authorized on the onvif interface. The only password you can set and change is that of their cloud platform and app, but it is not used for onvif. I tested it successfully with other generic onvif clients that support empty passwords.
Thank you!

@johnjoemorgan
Copy link

johnjoemorgan commented May 22, 2020

@hunterjm Some budget IP cameras such as Digoo do not use a password "out of the box" and in fact the only way to update the password is to reflash the units with custom code. Agreed not a purchase of choice but in some countries the range of decent, budget ONVIF cameras is very limited

hunterjm added a commit to hunterjm/home-assistant that referenced this issue May 23, 2020
MartinHjelmare pushed a commit that referenced this issue May 24, 2020
* fallback to device serial number if no mac available

* make password optional to fix #35904

* update tests to reflect new flow

* fix snake case and AsyncMock

* add comments around why weird things are being done
frenck pushed a commit that referenced this issue May 26, 2020
* fallback to device serial number if no mac available

* make password optional to fix #35904

* update tests to reflect new flow

* fix snake case and AsyncMock

* add comments around why weird things are being done
kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this issue May 28, 2020
* fallback to device serial number if no mac available

* make password optional to fix home-assistant#35904

* update tests to reflect new flow

* fix snake case and AsyncMock

* add comments around why weird things are being done

Took 12 seconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants