Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logbook doesn't filter anymore automations #36576

Closed
luca-angemi opened this issue Jun 8, 2020 · 8 comments · Fixed by #36727
Closed

Logbook doesn't filter anymore automations #36576

luca-angemi opened this issue Jun 8, 2020 · 8 comments · Fixed by #36727
Assignees
Milestone

Comments

@luca-angemi
Copy link
Contributor

luca-angemi commented Jun 8, 2020

The problem

Automation used to be filter based on yaml config for logbook. Might be related to #36356?

Environment

  • Home Assistant Core release with the issue: 0.111.0b3
  • Last working Home Assistant Core release (if known): 0.110.5
  • Operating environment (Home Assistant/Supervised/Docker/venv): venv
  • Integration causing this issue: logbook
  • Link to integration documentation on our website: https://www.home-assistant.io/integrations/logbook/

Problem-relevant configuration.yaml

logbook:
  exclude: 
    entities:
       - automation.cuckoo

Traceback/Error logs

image

Additional information

@dshokouhi
Copy link
Member

@luca-angemi seems you missed parts of the issue template, can you please edit your post and supply the requested info under Environment?

@luca-angemi
Copy link
Contributor Author

My apologies. Updated.

@dshokouhi dshokouhi added this to the 0.111.0 milestone Jun 8, 2020
@dshokouhi
Copy link
Member

Thank you, knowing its a beta issue is important :)

@cogneato
Copy link

cogneato commented Jun 8, 2020

Cannot reproduce this on 111.0b3. Are you refreshing the logger page?

Edit: Can reproduce by excluding an automation on 111.0b3

@luca-angemi
Copy link
Contributor Author

Yes, I refreshed it many times, algo logged from another browser in case of a cache issue.

image

@luca-angemi
Copy link
Contributor Author

The filter is excluding properly other type of entities I have excluded such as swtiches, sensors, inputs.
Only the automations seems to be the issue. That's why I referred to that PR.

@cogneato
Copy link

cogneato commented Jun 8, 2020

Ok, I first tested with any entity, and then added an automation, but it turns out I executed the wrong one, sorry. I can confirm the automation is not excluded.

@frenck
Copy link
Member

frenck commented Jun 12, 2020

My current guess is that my PR in #36356 broke this, especially since I've removed a piece from the _keep_event method that filtered this.

I think this needs more general solving, as this probably will affect others that use the async_describe_event (e.g. HomeKit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants