Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logbook filtering for described events #36727

Merged
merged 2 commits into from Jun 12, 2020
Merged

Fix logbook filtering for described events #36727

merged 2 commits into from Jun 12, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 12, 2020

Proposed change

Fixes logbook filtering for described logbook events.

If the described event contains an entity_id, it will be used for filtering (including the entity domain). If the described event has no entity_id, the originating domain is used for filtering.

Exempted from this is the EVENT_LOGBOOK_ENTRY, as this has always been the case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

Dev automation moved this from Needs review to Reviewer approved Jun 12, 2020
@frenck frenck added this to the 0.111.2 milestone Jun 12, 2020
@frenck frenck merged commit bf95658 into dev Jun 12, 2020
Dev automation moved this from Reviewer approved to Done Jun 12, 2020
@frenck frenck deleted the frenck-2020-0611 branch June 12, 2020 18:45
@bramkragten bramkragten mentioned this pull request Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Logbook doesn't filter anymore automations
4 participants