onvif stopped working in 2021.6.z #51530

ohadlevy · 2021-06-05T19:05:34Z

The problem

The camera is no longer found, error out with the following

Logger: homeassistant.config_entries
Source: util/dt.py:54
First occurred: 9:58:24 PM (1 occurrences)
Last logged: 9:58:24 PM

Error setting up entry garage - fa7d02c72d5c for onvif
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 293, in async_setup
    result = await component.async_setup_entry(hass, self)  # type: ignore
  File "/usr/src/homeassistant/homeassistant/components/onvif/__init__.py", line 72, in async_setup_entry
    if not await device.async_setup():
  File "/usr/src/homeassistant/homeassistant/components/onvif/device.py", line 98, in async_setup
    await self.async_check_date_and_time()
  File "/usr/src/homeassistant/homeassistant/components/onvif/device.py", line 172, in async_check_date_and_time
    dt_util.get_time_zone(device_time.TimeZone)
  File "/usr/src/homeassistant/homeassistant/util/dt.py", line 54, in get_time_zone
    return cast(dt.tzinfo, zoneinfo.ZoneInfo(time_zone_str))
  File "/usr/local/lib/python3.8/site-packages/backports/zoneinfo/_tzpath.py", line 95, in find_tzfile
    _validate_tzfile_path(key)
  File "/usr/local/lib/python3.8/site-packages/backports/zoneinfo/_tzpath.py", line 108, in _validate_tzfile_path
    if os.path.isabs(path):
  File "/usr/local/lib/python3.8/posixpath.py", line 62, in isabs
    s = os.fspath(s)
TypeError: expected str, bytes or os.PathLike object, not NoneType

What is version of Home Assistant Core has the issue?

core-2021.6

What was the last working version of Home Assistant Core?

core-2021.5

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

onvif

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.config_entries
Source: util/dt.py:54
First occurred: 9:58:24 PM (1 occurrences)
Last logged: 9:58:24 PM

Error setting up entry garage - fa7d02c72d5c for onvif
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 293, in async_setup
    result = await component.async_setup_entry(hass, self)  # type: ignore
  File "/usr/src/homeassistant/homeassistant/components/onvif/__init__.py", line 72, in async_setup_entry
    if not await device.async_setup():
  File "/usr/src/homeassistant/homeassistant/components/onvif/device.py", line 98, in async_setup
    await self.async_check_date_and_time()
  File "/usr/src/homeassistant/homeassistant/components/onvif/device.py", line 172, in async_check_date_and_time
    dt_util.get_time_zone(device_time.TimeZone)
  File "/usr/src/homeassistant/homeassistant/util/dt.py", line 54, in get_time_zone
    return cast(dt.tzinfo, zoneinfo.ZoneInfo(time_zone_str))
  File "/usr/local/lib/python3.8/site-packages/backports/zoneinfo/_tzpath.py", line 95, in find_tzfile
    _validate_tzfile_path(key)
  File "/usr/local/lib/python3.8/site-packages/backports/zoneinfo/_tzpath.py", line 108, in _validate_tzfile_path
    if os.path.isabs(path):
  File "/usr/local/lib/python3.8/posixpath.py", line 62, in isabs
    s = os.fspath(s)
TypeError: expected str, bytes or os.PathLike object, not NoneType

Additional information

No response

The text was updated successfully, but these errors were encountered:

djpremier · 2021-06-06T02:54:54Z

Possible fix:

# homeassistant/components/onvif/device.py - L172

dt_util.get_time_zone(device_time.TimeZone or dt_util.DEFAULT_TIME_ZONE)

bdraco · 2021-06-06T07:45:34Z

Do you have the tzdata package installed ?

ohadlevy · 2021-06-06T08:13:51Z

On Sun, Jun 6, 2021 at 10:45 AM J. Nick Koston ***@***.***> wrote: Do you have the tzdata package installed ?

On my host? of course, but I'm using official container images, which I assume has tzdata installed

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51530 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE5R72EZX4LPWIRBUUK6LTRMRSVANCNFSM46E4LGHQ> .

pszafer · 2021-06-07T13:15:23Z

@bdraco do you mean this tzdata? https://pypi.org/project/tzdata/ or system package?

Onvif component fail on Arch Linux, Alpine and Docker container, but it doesn't install tzdata from pypi.

bdraco · 2021-06-07T19:40:06Z

home-assistant/home-assistant.io#18077

pszafer · 2021-06-07T20:57:09Z

Thanks @bdraco . I missed that. How it is not breaking change I can't understand...

pszafer · 2021-06-07T21:22:36Z

ok, it's not tzdata which is missing, but bad json returned by Onvif device itself:

{                                                                                                             
    'DateTimeType': 'NTP',                                                                                             
    'DaylightSavings': False,                                                                                          
    'TimeZone': None,             
    'UTCDateTime': None,                                                                                               
    'LocalDateTime': {                                                                                                 
        'Time': {                                                                                                      
            'Hour': 21,                 
            'Minute': 21,                                                                                              
            'Second': 27                                  
        },                                                                                                             
        'Date': {                       
            'Year': 2021,                                                                                              
            'Month': 6,
            'Day': 7                                                                                                   
        }           
    },                                                                                                                 
    'Extension': None,                         
    '_attr_1': None                                                                                                    
}

pszafer · 2021-06-08T09:08:01Z

more info:
if HA init zoneinfo.ZoneInfo(None) or zoneinfo.ZoneInfo('None') then python is crashing:

    return cast(dt.tzinfo, zoneinfo.ZoneInfo(time_zone_str)) 
  File "/usr/lib/python3.9/zoneinfo/_tzpath.py", line 67, in find_tzfile
    _validate_tzfile_path(key)
  File "/usr/lib/python3.9/zoneinfo/_tzpath.py", line 81, in _validate_tzfile_path
    if os.path.isabs(path):
  File "/usr/lib/python3.9/posixpath.py", line 62, in isabs 
    s = os.fspath(s)

IMO this is bug in _validate_tzfile_path, it should raise ValueError on None, not crash. What do you think? Should I post bug in python3.9 issue tracker?
In the meantime I think I can make PR for this line

core/homeassistant/components/onvif/device.py

Lines 171 to 174 in 4007430

    
           tzone = ( 
        
               dt_util.get_time_zone(device_time.TimeZone) 
        
               or dt_util.DEFAULT_TIME_ZONE 
        
           )

to something like this:

def get_tzone():
  if not device_time.TimeZone:
    return dt_util.DEFAULT_TIME_ZONE
  return (dt_util.get_time_zone(device_time.TimeZone) or dt_util.DEFAULT_TIME_ZONE)
  

tzone = get_tzone()

so onvif module would still work.

andbad · 2021-06-08T11:05:03Z

more info:
if HA init zoneinfo.ZoneInfo(None) or zoneinfo.ZoneInfo('None') then python is crashing:
    return cast(dt.tzinfo, zoneinfo.ZoneInfo(time_zone_str)) 
  File "/usr/lib/python3.9/zoneinfo/_tzpath.py", line 67, in find_tzfile
    _validate_tzfile_path(key)
  File "/usr/lib/python3.9/zoneinfo/_tzpath.py", line 81, in _validate_tzfile_path
    if os.path.isabs(path):
  File "/usr/lib/python3.9/posixpath.py", line 62, in isabs 
    s = os.fspath(s)
IMO this is bug in _validate_tzfile_path, it should raise ValueError on None, not crash. What do you think? Should I post bug in python3.9 issue tracker?
In the meantime I think I can make PR for this line

core/homeassistant/components/onvif/device.py

Lines 171 to 174 in 4007430

tzone = (

dt_util.get_time_zone(device_time.TimeZone)

or dt_util.DEFAULT_TIME_ZONE

)

to something like this:
def get_tzone():
  if not device_time.TimeZone:
    return dt_util.DEFAULT_TIME_ZONE
  return (dt_util.get_time_zone(device_time.TimeZone) or dt_util.DEFAULT_TIME_ZONE)
  

tzone = get_tzone()
so onvif module would still work.

This works for me.

By(t)e

djpremier · 2021-06-08T11:07:59Z

Possible fix:

# homeassistant/components/onvif/device.py - L172

dt_util.get_time_zone(device_time.TimeZone or dt_util.DEFAULT_TIME_ZONE)

This one is "cleaner", doesn't it work?

pszafer · 2021-06-08T11:17:39Z

what if timezone would be set for as some garbage string eg Moon. get timezone would fail.

dt_util.get_time_zone(device_time.TimeZone or dt_util.DEFAULT_TIME_ZONE) or dt_util.DEFAULT_TIME_ZONE

djpremier · 2021-06-08T11:29:01Z

what if timezone would be set for as some garbage string eg Moon. get timezone would fail.
dt_util.get_time_zone(device_time.TimeZone or dt_util.DEFAULT_TIME_ZONE) or dt_util.DEFAULT_TIME_ZONE

But it wouldn't be a wrong event, don't you think? Because there is no logic in accepting an incorrect time zone.

That's what I think, as much as it's good to prevent the code from falling into error, accepting a value that isn't correct I believe it's not a good alternative.

pszafer · 2021-06-08T11:50:38Z

@djpremier I decided to fix it in dt_util. No need to change anything in onvif itself.

chemelli74 added the integration: onvif label Jun 5, 2021

probot-home-assistant bot assigned hunterjm Jun 5, 2021

pszafer mentioned this issue Jun 8, 2021

Fix Onvif get_time_zone from device #51620

Merged

21 tasks

frenck closed this as completed in #51620 Jun 8, 2021

github-actions bot locked and limited conversation to collaborators Jul 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onvif stopped working in 2021.6.z #51530

onvif stopped working in 2021.6.z #51530

ohadlevy commented Jun 5, 2021

djpremier commented Jun 6, 2021

bdraco commented Jun 6, 2021

ohadlevy commented Jun 6, 2021 via email

pszafer commented Jun 7, 2021

bdraco commented Jun 7, 2021

pszafer commented Jun 7, 2021

pszafer commented Jun 7, 2021

pszafer commented Jun 8, 2021

andbad commented Jun 8, 2021

djpremier commented Jun 8, 2021

pszafer commented Jun 8, 2021

djpremier commented Jun 8, 2021

pszafer commented Jun 8, 2021

onvif stopped working in 2021.6.z #51530

onvif stopped working in 2021.6.z #51530

Comments

ohadlevy commented Jun 5, 2021

The problem

What is version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

djpremier commented Jun 6, 2021

bdraco commented Jun 6, 2021

ohadlevy commented Jun 6, 2021 via email

pszafer commented Jun 7, 2021

bdraco commented Jun 7, 2021

pszafer commented Jun 7, 2021

pszafer commented Jun 7, 2021

pszafer commented Jun 8, 2021

andbad commented Jun 8, 2021

djpremier commented Jun 8, 2021

pszafer commented Jun 8, 2021

djpremier commented Jun 8, 2021

pszafer commented Jun 8, 2021