-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shark IQ Integration can't be added - Unexpected error #60422
Comments
sharkiq documentation |
Hey there @ajmarks, mind taking a look at this issue as it has been labeled with an integration ( |
Hi there, |
I'm in EU too. For EU there is sharkclean.co.uk and sharkclean.de There is also sharkclean.com. I've registered a second account there, which works with the login. |
Indeed.. |
There seems to be a pull request on the initial repo: Can someone with enough rights implement the changes on the HA official addon? |
Can anyone help on this issue please ? |
I am having the same unexpected error issue here in Germany, and I too suspect that is the fact that Shark has region specific logins. IE, my login doesn't work on the US site, but only on the DE site. Does anyone have any instructions on how to switch the branch that the OS is based on when running the HA OS on a Pi3? Or is there any info on when the fix might be integrated. I would be happy to assist intesting. |
That's it, the current integration does not work on the EU (Different servers) Basically all i had to do was:
All this could have been avoided if that PR was merged, but since it has been more than 6 months with no news, i wouldn't expect it to be. I can upload the custom integration if anyone needs it but i wont maintain it. |
Yes, please upload your integration. It would be greatly appreciated. |
@Draes thank you, very much appreciated! |
Thank you! |
Thanks! Works perfectly! |
Is it still working perfectly? |
Actually, the integration needs to be reloaded every 24-48hours. |
Known issue on the "official" integration, see here for the US/Worldwide fix: |
There should be no URL that avoids the need to reload. That issue is on the client side, failing to fetch a new token when the current one in use expires. On startup, the integration fetches a new token anyway though, which is why a restart "solves" the issue. If your URLs are working for any amount of time at all, they're the correct URLs. The issue is in the authentication implementation within sharkiqpy itself. |
@travipross understood, I misunderstood your fix ; I thought there was a change in the API that resulted in frequent token expiration. Anyway, clear now, thanks. So the issue should actually be fixable by actually having a token request once the previous one is expired. |
Hi everyone, we recently merged a PR to If you have issues or fixes that have not been addressed yet, please open an issue pr PR in https://github.com/JeffResc/sharkiq and we'll get fixes merged into Home Assistant as quickly as possible. Currently we do not have support for automatically refreshing the token, but it should be a fairly easy fix. If anyone would like to submit a PR we could use the help as myself and the other maintainers are still trying to get existing PRs migrated over from the legacy repo. Discussion for the token refresh issue at JeffResc/sharkiq#5 On that note, @Draes we are working on migrating a PR from the original integration that brings EU support into the main integration, so hopefully soon you will be able to just use the integration that ships with Home Assistant core. |
Very excited to see this project given a new set of eyes, as I've now got two Shark vacuums integrated with Home Assistant (and by proxy, Google Assistant). I have far more complex cleaning schedules set up through home assistant than what Shark provides, but it's been really disappointing to sometimes lose access entirely. |
Looking forward to this being resolved. I can live with the iOS app for now, but I like having everything centralized in HASS |
Getting the OP error on US servers. Is there a reason not to just fix in core? |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
@ github-actions bot - get that |
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
Issue is still present on the lastest HA release. Keep this open so I don't forget. Might look into this later. |
Sorry it took so long everyone! Unfortunately I was laid off in TheGreatTechLayoffs™️ and have had to spend all of my time job hunting. Got a new job thankfully so I'm trying to get all of this knocked out before I start next week. PR IS UP #89349 Hopefully things will be more streamlined moving forward. Thanks for your patience! |
Thanks Funky! Glad to hear your back on your feet as well. |
The problem
Trying to add the Shark IQ Integration to my HA instance (via the Integration UI) always results in the same error message: "Unexpected error"
I've attached a stacktrace from the error log of HA core.
I've also followed the troubleshooting section of the integration documentation and turned off all adblockers - without luck.
What version of Home Assistant Core has the issue?
core-2021.11.5
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Shark IQ
Link to integration documentation on our website
https://www.home-assistant.io/integrations/sharkiq
Example YAML snippet
No response
Anything in the logs that might be useful for us?
Additional information
Submitting the form with a wrong username/password results in the exact same error and stacktrace.
The text was updated successfully, but these errors were encountered: