New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SharkIQ token expiration #89357
Fix SharkIQ token expiration #89357
Conversation
Hey there @JeffResc, @AritroSaha10, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Glad you are doing okay! Thanks for your work. |
Dependency requirements have been merged to |
1426b3b
to
c245e90
Compare
I've marked this PR, as changes are requested that need to be processed above. Thanks! 👍 ../Frenck |
@Swamp-Ig I took an alternative approach that should negate the need to attempt re-auth in the exception blocks. Hopefully that alleviates your concerns. |
@frenck I took an alternative approach that should alleviate the concerns from @Swamp-Ig. I know you all are getting ready for the 2023.4 release tomorrow, but if this looks good to you, I know the community would love to see this bug fix soon. Could it potentially be a candidate for a minor release (2023.4.X)? |
That's better :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @funkybunch 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Yup, my guess is it is related to some changes to the tests file that was merged in the other day. I'll have it cleaned up soon. |
@frenck All set! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround @funkybunch 👍
../Frenck
Proposed change
This update fixes a bug in the SharkIQ integration where tokens are not refreshed after expiring, or are not refreshed ahead of expiring.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: