Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Assistant 2022.2.2 Insteon Keypad Buttons Broken #65857

Closed
srolomc opened this issue Feb 5, 2022 · 64 comments
Closed

Home Assistant 2022.2.2 Insteon Keypad Buttons Broken #65857

srolomc opened this issue Feb 5, 2022 · 64 comments

Comments

@srolomc
Copy link

srolomc commented Feb 5, 2022

The problem

After upgrading to Home Assistant 2022.2.2, I noticed the following issues with my Insteon Keypad (2334-222) button controls:

  • When I press the "Main" button on the Keypad, Home Assistant turns all buttons on, both when looking at the keypad device in Home Assistant, as well as on the keypad itself.
  • When I try to turn a keypad button on using Home Assistant, I see the keypad button light up, but in Home Assistant, the toggle turns off a few seconds later - Home Assistant does not appear to think that that the button was actually turned on. This behavior is inconsistent - sometimes the button stays enabled, sometimes it does not.

The previous version of Home Assistant (2021.12.10) exhibits the following (correct) behavior when doing the above:

  • Pressing the "Main" button only turns on that button, and nothing else.
  • When turning on a keypad button from Home Assistant, the keypad button turns on, and Home Assistant always recognizes and keeps the toggle enabled.

It appears that the latest version of Home Assistant has, at the very least, broken something with the Insteon keypad buttons.
Also, just to note, I have a Hub V2.

What version of Home Assistant Core has the issue?

2022.2.2

What was the last working version of Home Assistant Core?

2021.12.10

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Insteon

Link to integration documentation on our website

https://www.home-assistant.io/integrations/insteon/

Diagnostics information

No diagnostics available

Example YAML snippet

Issue is observable by interacting directly with the device

Anything in the logs that might be useful for us?

No specific errors were observed in the logs

Additional information

This problem is reproducible by doing the following:

  • Go to Devices -> Keypad Device
  • Turn on Keypad Main button
  • Observe other buttons also turn on
@probot-home-assistant
Copy link

insteon documentation
insteon source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @teharris1, mind taking a look at this issue as it has been labeled with an integration (insteon) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@fpitre75
Copy link

fpitre75 commented Feb 8, 2022

Same problem here, 5 keypadlinc (2334-222) but i didn't check before in other ha version. I just start with home assistant and insteon was a challenge and I keep keypalinc for the last and now i'm stock with this problem. Home Assistant 2022.2.3 , Docker, supervised, Insteon intégration with hub V2 (2245-222)

@teharris1
Copy link
Contributor

I have figured out what the issue is and it technically affects any device with multiple buttons/groups, for example any of the KPLs or On/Off outlets. I have figured out the solution and should be able to put in a pull request tomorrow. Until then please use 2021.12.x.

@srolomc
Copy link
Author

srolomc commented Feb 8, 2022

@teharris1 - I appreciate you looking into this so quickly and finding the problem. If a new version of Home Assistant becomes available with this fix merged in, I would be happy to test it out this week if you need, I would just need to know which version to pull down (I run Home Assistant through Docker). For the time being I am fine staying with 2021.12.10. Thanks again!

@fpitre75 - If you change the Docker image that you are using to "homeassistant/home-assistant:2021.12.10", things should work fine for you (they are for me) until this issue gets resolved in the latest version.

@teharris1
Copy link
Contributor

If you want to use 2022.02.x you can install the latest pyinsteon module. You need to be able to get to a command line to run docker. If you are just running a container you know how to do this. If you are running HassOS, you can install the SSH & Web Terminal add-on. Either way enter the following with the HA container running:

  1. docker exec -it homeassistant /bin/bash (This assumes your container is named homeassistant
  2. pip install --upgrade pyinsteon==1.0.15
  3. vi /usr/src/homeassistant/homeassistant/components/insteon/manifest.json
  4. Restart HA

This fixes the KPL issue. I am going to run it in my home system for a day or so before releasing it.

@srolomc
Copy link
Author

srolomc commented Feb 9, 2022

So I just tried this, and the keypad still does not seem to be working correctly; my automations are having issues that they did not have in the previous version of Home Assistant. I'll try to explain below what I tried and what the current observation is:

  • I turned on a light in one of my rooms (not with an Insteon switch), and my automation is supposed to see this and turn on the backlight for a button on the keypad. This works.
  • I turned on a light in another room (not with an Insteon switch), and my automation is supposed to see this and turn on the backlight for a different key on the keypad. This does turn on the backlight as expected; however, it turns also off the other button's backlight, subsequently shutting the lights off in the other room (from another automation seeing the button turn off), which is not supposed to happen. There should not be any interplay between these buttons.

When running with the previous version of Home Assistant, things behave as expected (i.e., turning lights on in one room and turning on the backlight for the corresponding keypad button does not affect the other keypad buttons).

I realize there is some complication with my setup/automations here, but something still seems to not be working right with the Keypad after updating my PyInsteon version and running with the latest version of Home Assistant as you suggested.

Please let me know if I can provide any further information to help debug.

@teharris1
Copy link
Contributor

I have also found some issues with my testing. Not sure if it is the same basic underlying problem but here is an example:

  1. Turn on the Main power of a KPL
  2. Turn on a KPL toggle button (i.e. button B)
  3. Turn off the Main power
    Result: Turns off both Main and Button B

I have posted an update to the main repository which can be installed using the steps above but with the following change:
2. pip install -e git+https://github.com/pyinsteon/pyinsteon.git@master#egg=pyinsteon

@srolomc
Copy link
Author

srolomc commented Feb 9, 2022

I tried it, and I'm still experiencing some strange behavior with other keypad buttons turning off when they shouldn't. I will note that I was not sure what to edit the manifest.json file with this time, so I left it as is. Maybe that was wrong?

@teharris1
Copy link
Contributor

If you don't edit the manifest.json file it reverts back to the original version which has the issue.

@teharris1
Copy link
Contributor

So here is another way to edit the manifest file without an editor

sed -i "s/1\.0\.14/1\.0\.15/g" /usr/src/homeassistant/homeassistant/components/insteon/manifest.json

@teharris1
Copy link
Contributor

Just realized I was not clear about what to edit in the manifest.json file. Sorry about that. You need to change the version of pyinsteon from 1.0.14 to 1.0.15.

@srolomc
Copy link
Author

srolomc commented Feb 9, 2022

Oh no problem, I assumed it was the version - I modified it the first time I tried the fix, I just wasn't sure if the version needed to be changed to 1.0.15 still for the second go around with the editable install. I should be able to try it again later tonight.

@teharris1
Copy link
Contributor

Any of the changes going forward are going to be version 1.0.15 until we hit the final changes. Then it will become 1.0.16 but I don't want to bump the version until we find the right set of fixes. I feel pretty good about where this most recent change is but still want to see how it performs in the real world.

@srolomc
Copy link
Author

srolomc commented Feb 10, 2022

Gotcha, makes sense. I just tried the latest update, and it still did not work for me unfortunately. Multiple buttons turn on when one other one is turned on (I believe this occurs when the Main button is turned on, as you also observed).

@fpitre75
Copy link

Thanks , i try this morning but i didn't know what to change in VI manifest.json. I made the change tonight but I'll ckeck tomorrow .

@shoeboo
Copy link

shoeboo commented Feb 16, 2022

The pyinsteon update has resolved the issue for me. I have been using it a couple days and haven't had any instances of multiple buttons being activated.

@srolomc
Copy link
Author

srolomc commented Feb 16, 2022

Has anything changed since 7 days ago? The update didn't work for me when I tried it then; I can give it another shot this weekend though to double check. I still need to stay on Home Assistant 2021.12.10.

@tennbaum
Copy link

tennbaum commented Feb 17, 2022

hay all,
Was just wondering about this too, after realizing that v.8 didnt solve it yet. will this fix be eventually implemented in one of the futures updates, or is there some other action needed to make it work?
cheers!

@shoeboo
Copy link

shoeboo commented Feb 17, 2022

I updated to 2022.2.7 (and then x.8) for the spotify fix and as expected, my keypads stopped working properly. I tried to run the fix again, but it is getting an error on step 2: pip install -e git+https://github.com/pyinsteon/pyinsteon.git@master#egg=pyinsteon
starting with building wheels for aiohttp (PEP 517)

@srolomc
Copy link
Author

srolomc commented Feb 19, 2022

@teharris1 - I just updated to the latest version of Home Assistant (and verified that the pyinsteon version is 1.0.16). Things are better, but I still have some issues that were not present in 2021.12.10. The problem with the main keypad button causing other buttons to turn on appears to be resolved, so that is great. I am; however, having the following problem:

  • When I have an automation turn a keypad button on after seeing another light turn on, the keypad button backlight lights up, as expected. When I look at the device in Home Assistant, however, it does not see its state as "on", it is instead "off". This only seems to happen for buttons other than the main button (i.e. the main button state changes seem to be detected by Home Assistant). For my use case, the issue is that I take other actions based on the state of the keypad buttons, but if Home Assistant does not detect state changes, then they will not work. Again, everything described above worked fine in Home Assistant version 2021.12.10.

Again, I appreciate you looking into these issues. If you think I should open up a new ticket for this, I can do that as well.

@tennbaum
Copy link

I can concord/conform that behavior on V.2022.2.9 regarding Insteon keypad 8 button.
"main" does not effect other buttons anymore, but correlation between other 7 and HA is flawed and inconsistent.
still way better than any other V2022.2.X

@teharris1
Copy link
Contributor

Thanks for the feedback. Any scenarios you can give me would be helpful. I have an 8 button and a 6 button so I should be able to test them. If you have automation that you can send the yaml for that may help too.

@srolomc
Copy link
Author

srolomc commented Feb 20, 2022

Sure, the simplest way that I am able to observe this problem is as follows:

  • In Home Assistant, click Configuration -> Devices & Services
  • Click the "Devices" link under the Insteon integration
  • Click on the keypad being used
  • On the physical keypad, press any button other than the Main button (this button must also have been associated with the HUB at some point) to turn it on
  • Home Assistant does not see the button turn on (the button's state stays off)

The problem described above does not occur for the Main button - Home Assistant does see state changes reflected when pressing the Main button on the keypad. Also, version 2012.12.10 does not have the problem noted above - state changes on keypad buttons other than the Main button are recognized by Home Assistant in that version.

I have attached sample automations that I use for turning the Keypad backlights off and on (note that I do have the device ID field filled out in my automations, I just cleared them before posting here).

Backligh_On_Sample.txt
Backlight_Off_Sample.txt

Thanks for your help!

@shoeboo
Copy link

shoeboo commented Feb 20, 2022

I use this functionality a lot in my setup and it is working appropriately in the updated version, although I am using a PLM instead of a hub. I have KPLs monitor the status of pool equipment, whole house audio, hue and z-wave lights and the status of the keypad and homeassistant have stayed in sync whether the button is lit due to a device being turned on by schedule, motion, voice assistant, or physically pushing the button.

@srolomc
Copy link
Author

srolomc commented Feb 20, 2022

@shoeboo - Interesting, maybe it has something to do with the Hub 2 specifically then? When I switch between Home Assistant 2012.12.10 and the current version, I definitely observe different behavior, as outlined in my previous post. Maybe that's a clue though, since it sounds like the difference between your setup and mine is the Hub.

@tennbaum
Copy link

tennbaum commented Feb 20, 2022

my setup uses the hub 2 as well, and my findings are not as @srolomc.
mine is pretty much back to normal. ill keep my eye on it next few days and update as needed.

@teharris1
Copy link
Contributor

Just curious, @miles267 and @srolomc, do you have any non-standard configuration of your KPLs such as radio button groups or toggle mode settings that are not out of the box defaults? I was able to see an issue when toggle mode is set to "on only" for a button, the new version does not appear to handle that correctly. It is actually off by a button (ie if H is a toggle button, the system things G is a toggle button, not H).

@miles267
Copy link

miles267 commented Mar 7, 2022

Just curious, @miles267 and @srolomc, do you have any non-standard configuration of your KPLs such as radio button groups or toggle mode settings that are not out of the box defaults? I was able to see an issue when toggle mode is set to "on only" for a button, the new version does not appear to handle that correctly. It is actually off by a button (ie if H is a toggle button, the system things G is a toggle button, not H).

Thank you @teharris1 so much for the follow-up. I am actually using a very basic Insteon Hub 2 controller (model 2245-2222) with a rather basic configuration. Simply a series of plug-in outlet power modules or light switches to toggle lights on/off. FYI, when I restart HA, upon restarting, the statuses of each of my Insteon devices are correctly updated and rendered in HA. However, if I attempt to toggle a light that is currently off into an "on" status using the native HA functionality, the insteon unit will temporarily flip to on (the intended device will power on), then HA will immediately toggle the status to "off" (however the Insteon device itself will remain on and powered as intended).

Also, I will put my config into debug and provide the requested log detail.

@miles267
Copy link

miles267 commented Mar 7, 2022

@teharris1 I've captured HA insteon debug info as you've requested. I've done a simple toggle of a basic power outlet controller at 12:52 in this simple capture. Please let me know if you require any additional details
insteon_HA_log.txt
.

@srolomc
Copy link
Author

srolomc commented Mar 8, 2022

@teharris1 - My KPL's are just in the standard configuration (all buttons are set to normal toggle mode), and I do not have any radio button groups setup. I should be able to get you a log tomorrow, I didn't have time tonight to mess around with anything unfortunately.

@teharris1
Copy link
Contributor

@miles267 I see the following:

  1. Turned on a device 37.43.85 at 12:52:34
  2. Turned ON the same device at 12:52:45
  3. Turned off the same devide at 12:52: 49
    With the exception that it is odd to see the same device turned on twice without being turned off, everything else looks fine.
    Can you give me a little bit more about what you expereienced in that time period? You indicated you toggled the outlet controller. Did you do that all within HA or was some of it done manually at the wall switch? Did HA respond to each step as expected?

@miles267
Copy link

miles267 commented Mar 8, 2022

Hi @teharris1 in the example above, I was toggling one of several of my Insteon wall/power outlet devices as an example of what I'm experiencing with all of mine currently. Here's the local behavior observed during the steps above:

1.) When I toggled device 37.43.85 from the OFF state to ON within the HA UI, the power toggle indicator in the HA slide to the on position and the physical device did in fact power on as expected. However the power toggle indicator in the UI return to off position. The device plugged in (a lamp) remained on despite the HA UI failing to reflect the status of the device as ON.
2.) In this step, I toggle the same device in the HA UI to ON (although it was already physically powered on). When the unit's power toggle in the UI was in the on position briefly, I then quickly
3.) toggled the HA UI slider to manually toggle it to OFF and the device's power turned off (the lamp powered off)

In my case, it seems a recent HA update (not sure which one) has interrupted my HA configuration's ability to accurately read in the power on/off statuses across my Insteon device. However, if I turn on a series of Insteon devices and then restart HA, when HA reinitializes the Insteon integration add-on, it will still correctly assess the power state of each of the devices and reflect them visually in the UI once only during the initial initialization process.

@teharris1
Copy link
Contributor

OK, I see what is happening. The messages are all following correctly and being heard by the modem. The issue is the messages are not triggering the state change as expected. So that is the good news, I know where the problem is. The bad news is it makes no sense why the messages would not be triggering the state changes so I need to dig in.

@teharris1
Copy link
Contributor

@srolomc I know you are using a hub v2, correct? @miles267 are you also using a hub v2? I am trying to see if this is a Hub specific problem or if people with a PLM are also having the issue.

@fpitre75 are you using anything other than X10? I believe there is a specific problem with X10 and given that you are using X10, I assume you are not using a Hub V2. Can you tell me what model of modem you are using?

@miles267
Copy link

miles267 commented Mar 8, 2022

Hi @teharris1 correct, I'm on a Hub v2 (Model 2245-222).

@teharris1
Copy link
Contributor

teharris1 commented Mar 8, 2022

Thanks. Also, what is the device type of 37.43.85 (cat and subcat)? Or model number?

@miles267
Copy link

miles267 commented Mar 8, 2022

Thanks. Also, what is the device type of 37.43.85 (cat and subcat)? Or model number?

Apologies for lack of info. The ID 37.43.85 aligns with an Insteon device model 2635-222 on/off module:
https://www.smarthome.com/products/insteon-2635-222-on-off-module

@srolomc
Copy link
Author

srolomc commented Mar 8, 2022

@teharris1 - To answer your previous question, yes, I do have a Hub v2

I have also attached a log with a test run using my automations with Home Assistant version 2022.3.3.
I started the test a bit after 17:39.
The sequence that I tested was:

  • Turned on a switch that should trigger an automation to turn on Keypad button D
  • Keypad button D lit up on the keypad, but HA did not see the state change for that button
  • Also, Main button A was supposed to turn on through an automation, and it did, and HA observed that state change
  • Turned on Keypad button G
  • HA observed the state change for this button, but then shut off the Main button (this also could've been due to something weird with my Automations I have given the current Insteon status instability)
  • Keypad button D eventually turned off (through Automation)

Please let me know if I can provide anymore details.

HA_Insteon_Log_2022_3_3.txt
.

@teharris1
Copy link
Contributor

@srolomc can you confirm a few things for me:

  1. 2B.FC.D0 is an 8 button KPL
  2. What device ID was used in step 1 above? Is this just a different button on 2B.FC.D0? It looks like you manually turned on button E on device 2B.FC.D0 at 17:40:23.
  3. When you say "Turned on Keypad button G", again is this for the same device 2B.FC.D0?

@teharris1 teharris1 mentioned this issue Mar 10, 2022
22 tasks
@teharris1
Copy link
Contributor

I have rolled back the change that was introduced in 2022.02 in order to restore the functionality. I believe I know the underlying issue but I need more time to test and confirm it works. This is going to take some time for me to get through.

@miles267
Copy link

I have rolled back the change that was introduced in 2022.02 in order to restore the functionality. I believe I know the underlying issue but I need more time to test and confirm it works. This is going to take some time for me to get through.

Thank you @teharris1. What is best way to receive this "update" (fix) on 2022.3.3?

@teharris1
Copy link
Contributor

It should show up in 2022.3.4 or 2022.3.5 so you just need to upgrade to the new version when it comes out.

@srolomc
Copy link
Author

srolomc commented Mar 10, 2022

@teharris1 - To answer your questions:

  1. Correct, 2B.FC.D0 is an 8 button KPL
  2. I manually turned on button E, which is on that same keypad
  3. I was mistaken when I said "button G", that's my bad. I actually meant button E, which again is on that same keypad

@srolomc
Copy link
Author

srolomc commented Mar 13, 2022

I just wanted to follow up - I updated Home Assistant to version 2022.3.4 and everything is working MUCH better now. I only did a couple of quick tests, but pyinsteon 1.0.13 appears to have fixed my issues - things are now working as expected.

@miles267
Copy link

Thank you SO MUCH @teharris1. With the update of HA core from 2022.3.3 to 2022.3.4 all of my Insteon integration is back to "normal" as I hoped and working as expected.

@fpitre75
Copy link

Thanks, keypad 8 buttons works well, but 6 button KPL 2486DWH6 (0x01, 0x09) (dimmer + button) doesn't work any work in progress ? else i'm gonna remove my 2 KPL 6 buttons. Main button turn off but for turn on need to use brigthness slider in HA to 100% after light turn on. A.B.C.D button doesn't work turn on in HA and 3 seconds later return to off. 1 Keypad remove replace by switch but other if possible i want to keep. Try to change for 8 button setting , locally works but insteon app and HA keep 6 buttons setting.

@teharris1
Copy link
Contributor

@fpitre75 This is a separate issue but happy to help. I have created a new issue here for your problem:
#70804
I will post info about how to diagnose the problem there.

@LSR19
Copy link

LSR19 commented Apr 26, 2022

Thanks, keypad 8 buttons works well, but 6 button KPL 2486DWH6 (0x01, 0x09) (dimmer + button) doesn't work any work in progress ? else i'm gonna remove my 2 KPL 6 buttons. Main button turn off but for turn on need to use brigthness slider in HA to 100% after light turn on. A.B.C.D button doesn't work turn on in HA and 3 seconds later return to off. 1 Keypad remove replace by switch but other if possible i want to keep. Try to change for 8 button setting , locally works but insteon app and HA keep 6 buttons setting.

I am new to HA now that Insteon turned off their cloud, and I'm having the same problem with my 6 button KPL. HA turn off control of the main On/Off buttons work, but when I turn on the HA switch it turns off after a couple seconds and the light never turns on. The only way to turn on the light is to use the slider.

@coincrazy1818
Copy link

2022.5 this problem continues. Is there a fix in the pipeline?

@teharris1
Copy link
Contributor

The issues that existed in 2022.2 were resolved. If you are seeing new issues I will open a new ticket. Please describe the issue with more clarity. #71305

I personally have 2 of these devices and they work well in 2022.5.

@coincrazy1818
Copy link

coincrazy1818 commented May 4, 2022 via email

@teharris1
Copy link
Contributor

Please do not use closed issues to document what you believe is a new problem even if you believe it is the same problem. The issue was closed by the person who opened it

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants