Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author of seven_segments platform #7954

Closed
frekel opened this issue Jun 8, 2017 · 6 comments · Fixed by #8001
Closed

Author of seven_segments platform #7954

frekel opened this issue Jun 8, 2017 · 6 comments · Fixed by #8001
Assignees

Comments

@frekel
Copy link

frekel commented Jun 8, 2017

I am wondering who created the seven_segments platform?
I need some changes to the script, but I am unsure how to handle these!

Thanks,
Frank

@pvizeli
Copy link
Member

pvizeli commented Jun 8, 2017

  1. Read this https://home-assistant.io/developers/
  2. Look to git history and you see who had write this platform
  3. Make a PR with your suggestion

@fabaff
Copy link
Member

fabaff commented Jun 8, 2017

I did.

@fabaff fabaff self-assigned this Jun 8, 2017
@frekel
Copy link
Author

frekel commented Jun 8, 2017

@pvizeli: I will look into it!

@fabaff: GREAT JOB! Thanks
This is my command: ssocr -D rotate 357 crop 145 170 180 62 -t 40 -d -1 test.jpg
As you can see I don't want to use make_mono and erosion.....

For now I changed the following:

    self._command = [
        'rotate', str(config[CONF_ROTATE]),
        'crop', str(config[CONF_X_POS]), str(config[CONF_Y_POS]),
        str(config[CONF_WIDTH]), str(config[CONF_HEIGHT]), '-t',
        str(config[CONF_THRESHOLD]), '-d', str(config[CONF_DIGITS]),
        self.filepath
    ]
    if config[CONF_SSOCR_TYPE]:
        self._command.insert(0, config[CONF_SSOCR_TYPE]);
    if config[CONF_MAKE_MONO]:
        self._command.insert(0, 'make_mono');
   
    self._command.insert(0, config[CONF_SSOCR_BIN])

(with the corrensponding changes in configuration.yaml and seven_segment.py (add default values and defining the extra config options)

  1. What is the best way to get these changes into the main repo?
  2. Do you have a seperate repo or do I need to follow pvizeli's advice?

Thanks for helping out!

Frank

@pvizeli
Copy link
Member

pvizeli commented Jun 8, 2017

@frekel nice. A small sugestion to ssocr. Can you add possibility to input a picture from stdin? That would be nice and save the life of SD cards. At the moment we need write the image to harddisk and after that we can parse it. If we are able to send it with stdin, we can process it direct like openalpr.

@frekel
Copy link
Author

frekel commented Jun 8, 2017

@pvizeli: If only I was a python man ;)

@pvizeli
Copy link
Member

pvizeli commented Jun 8, 2017

:) oh I missunderstand it

pvizeli pushed a commit that referenced this issue Jun 12, 2017
* Make it more flexible (fixes #7954)

* Fix var name
@balloob balloob mentioned this issue Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants