Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAPT Integration: "Unexpected RAPT payload version 2" in Log #93232

Closed
BerT666 opened this issue May 18, 2023 · 4 comments · Fixed by #93242 or #94718
Closed

RAPT Integration: "Unexpected RAPT payload version 2" in Log #93232

BerT666 opened this issue May 18, 2023 · 4 comments · Fixed by #93242 or #94718

Comments

@BerT666
Copy link

BerT666 commented May 18, 2023

The problem

The RAPT Integration is working well ( only Pill in use) but I see the following in the Logs:

Unexpected RAPT payload version 2, measurements may be incorrect!

Is there anything to worry about?

What version of Home Assistant Core has the issue?

core-2023.5.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

RAPT BLE

Link to integration documentation on our website

https://www.home-assistant.io/integrations/rapt_ble/#supported-devices

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Unexpected RAPT payload version 2, measurements may be incorrect!

Additional information

No response

@home-assistant
Copy link

Hey there @sairon, mind taking a look at this issue as it has been labeled with an integration (rapt_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rapt_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign rapt_ble Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


rapt_ble documentation
rapt_ble source
(message by IssueLinks)

@sairon
Copy link
Member

sairon commented May 18, 2023

@BerT666 It's a sanity check that is printed when one of the fields in the reported data has a different value than what was found during the reverse engineering of the protocol. In the previous version it was always 1, maybe recent firmware updates changed it. If the reported values seem correct, you may ignore it for now, but I will need to check why is the value different now and update the code accordingly. Thanks for reporting it!

@sairon
Copy link
Member

sairon commented May 18, 2023

I've just briefly checked it with FW 20230420_054501_98ef1a1 and can reproduce it too, it seems that the only change is that the new payload doesn't contain the MAC address anymore, which is actually nulled.
Pill with older FW, payload v1 (aabbccddeeff is device's MAC address)
5241505401aabbccddeeff949b44a69b5b00c0cc93dac46400
The same device, latest FW:
524150540200000000000094a344a6688000cecc95da926400

Hard to say why it was removed but since the field is not used in our integration, the change is harmless. I will do more investigation and prepare a fix later today.

sairon added a commit to sairon/rapt-ble that referenced this issue May 18, 2023
@sairon sairon mentioned this issue May 18, 2023
20 tasks
@sairon
Copy link
Member

sairon commented May 18, 2023

MAC address has been replaced by the "gravity velocity" value. I have opened PR with a fix for the warning, I will later add the new metrics to the reported sensor values as well once this PR is merged.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants