Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AussieBroadBand Fails #95665

Closed
eangulus opened this issue Jul 1, 2023 · 40 comments · Fixed by #99077, #101315 or #110253
Closed

AussieBroadBand Fails #95665

eangulus opened this issue Jul 1, 2023 · 40 comments · Fixed by #99077, #101315 or #110253

Comments

@eangulus
Copy link

eangulus commented Jul 1, 2023

The problem

Have a myAussie account, with 3 NBN services and a Voip Service on it. This account fails in HA.

I have 3 other seperate accounts, each with a single NBN service and nothing else on theme, and they all work perfectly.

What version of Home Assistant Core has the issue?

core-2023.6.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

AussieBroadband

Link to integration documentation on our website

No response

Diagnostics information

Logger: homeassistant.components.aussie_broadband
Source: components/aussie_broadband/init.py:48
Integration: Aussie Broadband (documentation, issues)
First occurred: 7:38:43 PM (8 occurrences)
Last logged: 7:43:42 PM

Unexpected error fetching 2345798 data: list index out of range
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/aussie_broadband/init.py", line 45, in async_update_data
return await client.get_usage(service_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aussiebb/asyncio/init.py", line 404, in get_usage
self.validate_service_type(service)
File "/usr/local/lib/python3.11/site-packages/aussiebb/baseclass.py", line 116, in validate_service_type
raise UnrecognisedServiceType(
aussiebb.exceptions.UnrecognisedServiceType: Service type service['type']='Hardware' service['name']='Hardware' - not recognised - please raise an issue about this - https://github.com/yaleman/aussiebb/issues/new

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 283, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 242, in _async_update_data
return await self.update_method()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/aussie_broadband/init.py", line 48, in async_update_data
f"Service {service_id} of type '{services[service_id]['type']}' was"
~~~~~~~~^^^^^^^^^^^^
IndexError: list index out of range

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Jul 1, 2023

Hey there @nickw444, @Bre77, mind taking a look at this issue as it has been labeled with an integration (aussie_broadband) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aussie_broadband can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign aussie_broadband Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


aussie_broadband documentation
aussie_broadband source
(message by IssueLinks)

@Bre77
Copy link
Contributor

Bre77 commented Jul 1, 2023

@yaleman we have another new service class.

service['type']='Hardware'

@yaleman
Copy link
Contributor

yaleman commented Jul 2, 2023

We do indeed! I'd love a PR please, I've got a lot on at the moment. 😅

@eangulus
Copy link
Author

If you guys need any information that will help fix this, I am happy to provide.

For your information the account I am trying to use with is a business account with 1 VoIP Server, 1 PABX service, and 3 NBN connections (2 FTTN and 1 FTTP).

@yaleman
Copy link
Contributor

yaleman commented Aug 26, 2023

The library's been updated, someone now needs to update it in Home Assistant and test.

@eangulus
Copy link
Author

eangulus commented Aug 26, 2023 via email

@yaleman
Copy link
Contributor

yaleman commented Aug 26, 2023

Then you're going to have to provide something more than "List index out of range" please, because that's decidedly NOT specific. You already ignored the original error message and posted about it on the wrong github repo, how about giving me something to work with.

@Bre77
Copy link
Contributor

Bre77 commented Aug 26, 2023

The library's been updated, someone now needs to update it in Home Assistant and test.

I'll get onto this @yaleman, thanks for picking up my slack on this one.

@eangulus
Copy link
Author

eangulus commented Sep 7, 2023

Just updated to 2023.9.0 and the problem is still there.

1 out ofr 4 of my services will not load. The error message I get is:

400, message='Bad Request', url=URL('https://myaussie-api.aussiebroadband.com.au/broadband/2345798/usage')

And for reference, after logging into myaussie, when I go to the link in the error message I get this:

{"message":"This service is not a broadband service."}

The account in question has 2 x VoIP Services, 2 FTTN NBN Services, 1 Fibre Service and 1 Hardware

@yaleman
Copy link
Contributor

yaleman commented Sep 7, 2023

That'll probably be the ID for the Hardware or something, can you look at the response to https://myaussie-api.aussiebroadband.com.au/services when you log into myaussie?

@eangulus
Copy link
Author

eangulus commented Sep 7, 2023

{"data":[{"service_id":2348784,"type":"VOIP","name":"VOIP","plan":"Business Everyday ($10)","description":"VOIP: 4 Deane ST, COONABARABRAN - 02 6842 2655","voipDetails":{"phoneNumber":"0268422655","barInternational":true,"divertNumber":null,"supportsNumberDiversion":true,"diversionActive":true,"diversionError":null},"nextBillDate":"2023-09-23T14:00:00Z","openDate":"2023-06-04T14:00:00Z","usageAnniversary":24,"address":null,"contract":null,"discounts":[]},{"service_id":2391497,"type":"NBN","name":"NBN","plan":"Business NBN 50Mbps\/20Mbps Unlimited ($79.00)","description":"NBN: LOT 4 GORDON ST, COONABARABRAN NSW - AVC000174217155","nbnDetails":{"product":"FTTN","poiName":"Dubbo","cvcGraph":"https:\/\/cvcs.aussiebroadband.com.au\/dubbolink3.png","speedPotential":{"downloadMbps":52,"uploadMbps":21,"lastTested":"2023-06-08T22:25:10Z"}},"nextBillDate":"2023-09-23T14:00:00Z","openDate":"2023-06-07T14:00:00Z","usageAnniversary":24,"ipAddresses":["144.6.38.218","2403:5811:7fff:f830::\/64","2403:5811:649d::\/48"],"address":{"subaddresstype":null,"subaddressnumber":null,"streetnumber":null,"streetname":"GORDON","streettype":"ST","locality":"COONABARABRAN","postcode":"2357","state":"NSW"},"contract":null,"discounts":[]},{"service_id":2363089,"type":"VOIP","name":"VOIP","plan":"Hosted PABX Standard","description":"Hosted PABX (per seat): UN 1, 28 Hawthorn ST, Dubbo - 0258099585","voipDetails":{"phoneNumber":"0258099585","barInternational":true,"divertNumber":null,"supportsNumberDiversion":false,"diversionActive":true,"diversionError":null},"nextBillDate":"2023-09-23T14:00:00Z","openDate":"2023-07-20T14:00:00Z","usageAnniversary":24,"address":null,"contract":null,"discounts":[{"amount":100,"discountType":"percentage_monthly","description":"Hosted PABX First 3 Months Free","startDate":"2023-07-03","finishDate":"2023-10-02"}]},{"service_id":2348667,"type":"NBN","name":"NBN","plan":"Business NBN 100Mbps\/40Mbps Unlimited ($109.00)","description":"NBN: UN 1, 28 HAWTHORN ST, DUBBO NSW - AVC000174581370","nbnDetails":{"product":"FTTN","poiName":"Dubbo","cvcGraph":"https:\/\/cvcs.aussiebroadband.com.au\/dubbolink3.png","speedPotential":{"downloadMbps":137,"uploadMbps":49,"lastTested":"2023-06-25T04:24:20Z"}},"nextBillDate":"2023-09-23T14:00:00Z","openDate":"2023-06-22T14:00:00Z","usageAnniversary":24,"ipAddresses":["144.6.39.99","2403:5811:7fff:580::\/64","2403:5811:4e0e::\/48"],"address":{"subaddresstype":"UN","subaddressnumber":"1","streetnumber":"28","streetname":"HAWTHORN","streettype":"ST","locality":"DUBBO","postcode":"2830","state":"NSW"},"contract":null,"discounts":[]},{"service_id":2345930,"type":"NBN","name":"NBN","plan":"Business NBN 100Mbps\/40Mbps Unlimited ($109.00)","description":"NBN: 16 GUNDARRA ST, DUBBO NSW - AVC000173339304","nbnDetails":{"product":"Fibre","poiName":"Dubbo","cvcGraph":"https:\/\/cvcs.aussiebroadband.com.au\/dubbolink3.png"},"nextBillDate":"2023-09-23T14:00:00Z","openDate":"2023-05-23T14:00:00Z","usageAnniversary":24,"ipAddresses":["144.6.37.240","2403:5811:7fff:a02d::\/64","2403:5811:25b6::\/48"],"address":{"subaddresstype":null,"subaddressnumber":null,"streetnumber":"16","streetname":"GUNDARRA","streettype":"ST","locality":"DUBBO","postcode":"2830","state":"NSW"},"contract":null,"discounts":[{"amount":20,"discountType":"absolute","description":"$20 off for 6 months (24\/May\/2023 -> 23\/Nov\/2023)","startDate":"2023-05-24","finishDate":"2023-11-23"}]},{"service_id":2345798,"type":"Hardware","name":"Hardware","plan":"Hardware Outright","description":"Hardware - NF20MESH (Outright Purchase)","nextBillDate":"2023-09-23T14:00:00Z","openDate":"2023-06-07T14:00:00Z","usageAnniversary":24,"address":null,"contract":null,"discounts":[]}],"links":{"first":"https:\/\/myaussie-api.aussiebroadband.com.au\/services?page=1","last":"https:\/\/myaussie-api.aussiebroadband.com.au\/services?page=1","prev":null,"next":null},"meta":{"current_page":1,"from":1,"last_page":1,"links":[{"url":null,"label":"« Previous","active":false},{"url":"https:\/\/myaussie-api.aussiebroadband.com.au\/services?page=1","label":"1","active":true},{"url":null,"label":"Next »","active":false}],"path":"https:\/\/myaussie-api.aussiebroadband.com.au\/services","per_page":10,"to":6,"total":6}}

@yaleman
Copy link
Contributor

yaleman commented Sep 7, 2023

Yep, that's the hardware.

@eangulus
Copy link
Author

Why is this closed? THe problem and error is still there. Just applied all updates minutes ago and the error still exists.

This is NOT SOLVED/FIXED.

@Bre77
Copy link
Contributor

Bre77 commented Sep 27, 2023

Why is this closed? THe problem and error is still there. Just applied all updates minutes ago and the error still exists.

This is NOT SOLVED/FIXED.

Home Assistant closes issues automatically when targeted by a PR.

Are you getting the same error as the original issue, or a new error saying it's not a broadband service? I believe the latter is expected behaviour.

You said only three services work, is that your 2x NBN and 1x Fibre? If so it sounds like everything is working as expected.

@eangulus
Copy link
Author

eangulus commented Oct 2, 2023

Not everything works as expected.

I have 3 separate accounts. 2 of the accounts work perfectly.

It's the one with the above error that errors. How is an error expected functionality??

The account with an error, has 2 Fibre and a FTTN service, and a Hosted PBX service. Nothing shows for anything under that account. The error stops anything from coming thru for that account.

The json dump I posted last, is from that account, and nothing shows in Home Assistant. I simply get an error on the addon and then nothing works.

Personally an outright error should never be expected behaviour. It should fail cleanly, as in if it is indeed the hardware part that is causing the problem. Ignore it then. This should then allow at least the broadband services to work.

@eangulus
Copy link
Author

eangulus commented Oct 2, 2023

You said only three services work, is that your 2x NBN and 1x Fibre? If so it sounds like everything works as expected.

I think it wasn't clear. When I said I had 3 services working, I mean, accounts. 3 separate accounts, each with only a single broadband service on them and nothing more.

The error one, is a 4th Account, that has 3 NBN services and the Hosted PBX.

@Bre77
Copy link
Contributor

Bre77 commented Oct 2, 2023

You said only three services work, is that your 2x NBN and 1x Fibre? If so it sounds like everything works as expected.

I think it wasn't clear. When I said I had 3 services working, I mean, accounts. 3 separate accounts, each with only a single broadband service on them and nothing more.

The error one, is a 4th Account, that has 3 NBN services and the Hosted PBX.

Right, I understand now. I've spoken with @yaleman and we'll need to establish a new path forward given the pyAussieBB library and Home Assistant are currently incompatible.

@yaleman
Copy link
Contributor

yaleman commented Oct 2, 2023

This one should be patchable in the same way as the previous fix, with a silent ignore-errors handler for that device type in... wherever the error's occurring.

@Bre77
Copy link
Contributor

Bre77 commented Oct 3, 2023

@home-assistant reopen

@home-assistant home-assistant bot reopened this Oct 3, 2023
@Bre77
Copy link
Contributor

Bre77 commented Oct 3, 2023

Found the actual root cause, PR has been raised to fix this. Its my fault for not looking at the full error message in the first place, because the issue was rather simple.

@eangulus
Copy link
Author

eangulus commented Oct 3, 2023

Thanks heaps.

I'm not familiar with the placing/patching process, how long can I expect before this fix should be in?

@Bre77
Copy link
Contributor

Bre77 commented Oct 3, 2023

Either in a few days or a month.

@Bre77
Copy link
Contributor

Bre77 commented Oct 4, 2023

The fixes have been shipped in 2023.10.0b7, so will also be in 2023.10

@eangulus
Copy link
Author

eangulus commented Oct 6, 2023

Ive updated and still broken.

Home Assistant 2023.10.0
Supervisor 2023.10.0
Operating System 10.5
Frontend 20231002.0 - latest

Is there any information I can share to help get this fixed?

@Bre77
Copy link
Contributor

Bre77 commented Oct 9, 2023

A fresh copy of your logs where is failing in a new issue would be best.

@eangulus
Copy link
Author

eangulus commented Oct 9, 2023

How do I get them?

The error message I get is "Service 2345798 was unrecognised"

I also enabled debug logs a while ago but I cant find anything in the logs, but not sure I am looking in the correct place.

@eangulus
Copy link
Author

eangulus commented Oct 9, 2023

The only thing I can find in the logs is this:

2023-10-09 13:55:21.316 WARNING (MainThread) [homeassistant.config_entries] Config entry 'allsetsolutions' for aussie_broadband integration not ready yet: Service 2345798 was unrecognised; Retrying in background

@yaleman
Copy link
Contributor

yaleman commented Oct 9, 2023 via email

@Bre77
Copy link
Contributor

Bre77 commented Oct 9, 2023

The only thing I can find in the logs is this:

2023-10-09 13:55:21.316 WARNING (MainThread) [homeassistant.config_entries] Config entry 'allsetsolutions' for aussie_broadband integration not ready yet: Service 2345798 was unrecognised; Retrying in background

Try to remove your Aussie Broadband account from Home Assistant and add it back again.

@eangulus
Copy link
Author

eangulus commented Oct 9, 2023

Already tried removing and readding several times, just the entity and also the entire addon too. On 2 different systems as well. I get the same error.

@eangulus
Copy link
Author

Why is this closed?

Ive now done another update to 2023.10.1 and this is still not fixed?

@Bre77
Copy link
Contributor

Bre77 commented Oct 16, 2023

@home-assistant reopen

@home-assistant home-assistant bot reopened this Oct 16, 2023
@eangulus
Copy link
Author

What is happening with this? Is there anything I should be doing?

@yaleman
Copy link
Contributor

yaleman commented Oct 24, 2023

This isn't a full-time job for the people helping you @eangulus, I'm sure it'll get looked at when someone has time.

@eangulus
Copy link
Author

I wasn't hurrying anyone.

I was simply making sure I have done everything I needed to do for this to then get picked up and looked at.

I didn't know if anyone was waiting on logs, or more information from me.

@Bre77
Copy link
Contributor

Bre77 commented Oct 25, 2023

@eangulus can you please go to devices and see if you can find Service 2345798 (its name will be whatever its called in MyAussie). If you can click on it, click the pencil in the top right, and disable it, then restart Home Assistant.

@eangulus
Copy link
Author

Just tried on one system where I don't have any other accounts other than the troubled one, there are no devices at all from the ABB add-on. I did check for already disabled devices too.

I will check my home one where I have 3 different accounts.

@eangulus
Copy link
Author

Just letting everyone know that nothing has changed (still fails) as of version:

Core 2023.12.1
Supervisor 2023.11.6
Operating System 11.2
Frontend 20231208.2

@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@eangulus
Copy link
Author

This should not be closed, as it hasnt been fixed yet.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.