Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Comelit alarm data retrieval #100067

Merged

Conversation

chemelli74
Copy link
Contributor

Proposed change

Remove alarm data retrieval from bridge as not all installation have an alarm connected.
Alarm config and data will be retrieved directly from VEDO alarm board in a future implementation.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 added this to the 2023.9.2 milestone Sep 10, 2023
@MartinHjelmare MartinHjelmare changed the title Comelit: remove alarm data retrieval Remove Comelit alarm data retrieval Sep 10, 2023
@chemelli74 chemelli74 merged commit 0fb678a into home-assistant:dev Sep 11, 2023
21 checks passed
@chemelli74 chemelli74 deleted the chemelli74-comelit-fix-alarm branch September 11, 2023 06:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comelit integration in the new version
3 participants