Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump hatasmota to 0.7.2 #100129

Merged
merged 1 commit into from Sep 11, 2023
Merged

Bump hatasmota to 0.7.2 #100129

merged 1 commit into from Sep 11, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Sep 11, 2023 •
edited by thecode

Proposed change

Bump hatasmota from 0.7.1 to 0.7.2

Release notes: https://github.com/emontnemery/hatasmota/releases/tag/0.7.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2023.9.2 milestone Sep 11, 2023
@thecode
Copy link
Member

thecode commented Sep 11, 2023

Fixes #100089

@thecode
Copy link
Member

thecode commented Sep 11, 2023

I am testing this right now

thecode
thecode approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both on prod (2023.9.1) and dev, fixes single output devices. Thanks! 👍

@kodiakastu kodiakastu mentioned this pull request Sep 11, 2023
Closed
@bdraco bdraco merged commit 18e08bc into dev Sep 11, 2023
34 checks passed
@bdraco bdraco deleted the bump_hatasmota_0.7.2 branch September 11, 2023 16:35
balloob pushed a commit that referenced this pull request Sep 12, 2023
@emontnemery @balloob
Bump hatasmota to 0.7.2 (#100129)
8e2fa67
@balloob balloob mentioned this pull request Sep 12, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@thecode thecode thecode approved these changes

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed has-tests integration: tasmota Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.9.2
Development

Successfully merging this pull request may close these issues.

Tasmota 2023.9.0 now show device name and frendly name from tasmota devices
5 participants
@emontnemery @thecode @bdraco @joostlek @balloob