Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Govee H5055 #100365

Merged
merged 2 commits into from Oct 17, 2023
Merged

Conversation

blalor
Copy link
Contributor

@blalor blalor commented Sep 14, 2023

Proposed change

Bump govee-ble to v0.24.0, adding support for Govee H5055 meat thermometer.

https://github.com/Bluetooth-Devices/govee-ble/releases/tag/v0.24.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @blalor

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @bdraco, @PierreAronnax, mind taking a look at this pull request as it has been labeled with an integration (govee_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of govee_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign govee_ble Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@edenhaus
Copy link
Contributor

Drafting as the docs PR is required. Please mark it "Ready for review" after creating a PR for the docs

@edenhaus edenhaus marked this pull request as draft September 26, 2023 12:02
@blalor
Copy link
Contributor Author

blalor commented Sep 26, 2023 via email

@bdraco
Copy link
Member

bdraco commented Sep 26, 2023

Just needs to be added to the supported devices list https://www.home-assistant.io/integrations/govee_ble/#supported-devices

@tjhorner
Copy link
Contributor

@bdraco @edenhaus I've created the docs PR to help push this along :)

home-assistant/home-assistant.io#29385

@bdraco bdraco marked this pull request as ready for review October 17, 2023 02:08
@bdraco
Copy link
Member

bdraco commented Oct 17, 2023

Thanks @tjhorner

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Oct 17, 2023
@bdraco
Copy link
Member

bdraco commented Oct 17, 2023

Thanks @blalor & @tjhorner

@bdraco bdraco merged commit 912032e into home-assistant:dev Oct 17, 2023
53 checks passed
@blalor blalor deleted the blalor/govee-h5055 branch October 17, 2023 18:34
@blalor
Copy link
Contributor Author

blalor commented Oct 17, 2023

Thank you @tjhorner !

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: govee_ble Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants