New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Energyzero get_prices service #100499
Add Energyzero get_prices service #100499
Conversation
Hey there @klaasnicolaas, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@klaasnicolaas do you maybe have some time to look at this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure CI is passing
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Btw your example can be simplified by using actions in your template |
@edenhaus can I fix this CI run myself? https://github.com/home-assistant/core/actions/runs/6300571239/job/17106518193 |
Nope only members can retrigger the job. |
@edenhaus is there any way to get this though without a review from the code owner (or am I being a bit too eager)? |
By waiting patiently and no, we are certainly not going to just skip the code owner just to get a PR through 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved, don't see anything strange in the code at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final remark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iamrgroot 👍
@edenhaus @iamrgroot @klaasnicolaas I want to revert this PR, as I think the approach is wrong. Let me make a revert and explain why in the revert PR. ../Frenck |
@iamrgroot Yup. This is the right direction though, but we should not have merged this. ../Frenck |
Proposed change
Follow-up of #100370 (comment)
This PR adds a service that returns the energy and gas prices as response. This allows someone to put it into a template sensor:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: