Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Refoss integration #100573

Merged
merged 157 commits into from Dec 22, 2023
Merged

Add Refoss integration #100573

merged 157 commits into from Dec 22, 2023

Conversation

ashionky
Copy link
Contributor

@ashionky ashionky commented Sep 19, 2023

Proposed change

Add Refoss integration

library: https://github.com/ashionky/refoss_ha

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@ashionky
Copy link
Contributor Author

Please don't merge the dev every day into this PR. I just wanted to let you know that this is not required and should be avoided as each time, the CI must be running.

ok, before I was worried that the code would fall behind the main branch。

homeassistant/components/refoss/switch.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/entity.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/entity.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 15, 2023 08:08
@ashionky ashionky marked this pull request as ready for review November 15, 2023 12:36
@ashionky
Copy link
Contributor Author

@joostlek Modified, thanks。

@ashionky
Copy link
Contributor Author

Modified,please check it

@ashionky
Copy link
Contributor Author

ashionky commented Dec 4, 2023

Hello, Still waiting?

@ashionky
Copy link
Contributor Author

ashionky commented Dec 8, 2023

@joostlek @Lash-L @edenhaus Has this PR sunk? No response

@jpbede
Copy link
Member

jpbede commented Dec 12, 2023

Reviewing PRs for new integrations takes some time as they are quite large compared to others. Please be patient and please avoid pulling people into conversations. The reviewers revisit your PR when they have time or someone other will pick it up. Thanks a lot 👍

Copy link
Contributor

@Bre77 Bre77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only noticed minor stuff that probably isnt super important.

homeassistant/components/refoss/bridge.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/refoss/coordinator.py Outdated Show resolved Hide resolved
@ashionky
Copy link
Contributor Author

I only noticed minor stuff that probably isnt super important.

Thanks, but i don't know when it will be merged

@ashionky ashionky requested a review from Bre77 December 18, 2023 03:21
@ashionky ashionky closed this Dec 18, 2023
@jpbede jpbede mentioned this pull request Dec 18, 2023
20 tasks
@ashionky ashionky reopened this Dec 19, 2023
homeassistant/components/refoss/__init__.py Outdated Show resolved Hide resolved
@joostlek joostlek merged commit 102c7f1 into home-assistant:dev Dec 22, 2023
53 checks passed
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 23, 2023
* refoss

* refoss

* refoss

* refoss

* refoss modify

* ip

* 8.22

* format

* format

* format

* bugfix

* test

* test

* test

* test

* test

* test

* 9.1

* refosss

* refoss

* refoss

* refoss

* refoss

* refoss

* refoss

* refoss

* test

* requirements_test_all.txt

* codeowners

* refoss

* Review feedback repair

* strings

* refoss

* refoss

* refoss

* 1.1.1

* 1.1.2

* refoss

* refoss

* refoss.1.1.7

* refoss-gree

* 1.1.7

* test

* refoss

* test refoss

* test refoss

* refoss-test

* refoss

* refoss

* test

* test

* refoss

* CODEOWNERS

* fix

* Update homeassistant/components/refoss/__init__.py

---------

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants