Adjust hassfest.manifest based on config.action #100577
Merged
+11
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently, when calling
hassfest.manifest.validate
, once we retrieve all the integration manifests that were not sorted,hassfest
will try to run prettier on the corresponding integrations, regardless of whether the modeconfig.action
isgenerate
orvalidate
. Currently, when runninghassfest
as a GitHub action, which runs the tool invalidate
mode, improperly sorted manifests leads to the error below because the action's container doesn't have prettier installed.In discussion with @ludeeus , we should instead have branching logic based on the
config.action
so that we only take the steps that are needed. In the case ofvalidate
, which is what the GitHub action uses, there is no reason to run prettier because we aren't actually generating new files. While this was done to fix the GH action, this is a general improvement to the tool anywayType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: